From: John Fastabend <john.fastabend@gmail.com>
To: Quentin Monnet <quentin@isovalent.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
Quentin Monnet <quentin@isovalent.com>,
Richard Palethorpe <rpalethorpe@suse.com>,
Michael Kerrisk <mtk.manpages@gmail.com>
Subject: RE: [PATCH bpf-next v3 0/3] tools: bpftool: probe features for unprivileged users
Date: Wed, 29 Apr 2020 13:10:56 -0700 [thread overview]
Message-ID: <5ea9df505abc3_4d8d2ae8075c45bc7d@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <20200429144506.8999-1-quentin@isovalent.com>
Quentin Monnet wrote:
> This set allows unprivileged users to probe available features with
> bpftool. On Daniel's suggestion, the "unprivileged" keyword must be passed
> on the command line to avoid accidentally dumping a subset of the features
> supported by the system. When used by root, this keyword makes bpftool drop
> the CAP_SYS_ADMIN capability and print the features available to
> unprivileged users only.
>
> The first patch makes a variable global in feature.c to avoid piping too
> many booleans through the different functions. The second patch introduces
> the unprivileged probing, adding a dependency to libcap. Then the third
> patch makes this dependency optional, by restoring the initial behaviour
> (root only can probe features) if the library is not available.
>
> Cc: Richard Palethorpe <rpalethorpe@suse.com>
> Cc: Michael Kerrisk <mtk.manpages@gmail.com>
>
> v3: Update help message for bpftool feature probe ("unprivileged").
>
> v2: Add "unprivileged" keyword, libcap check (patches 1 and 3 are new).
>
> Quentin Monnet (3):
> tools: bpftool: for "feature probe" define "full_mode" bool as global
> tools: bpftool: allow unprivileged users to probe features
> tools: bpftool: make libcap dependency optional
>
> .../bpftool/Documentation/bpftool-feature.rst | 12 +-
> tools/bpf/bpftool/Makefile | 13 +-
> tools/bpf/bpftool/bash-completion/bpftool | 2 +-
> tools/bpf/bpftool/feature.c | 143 +++++++++++++++---
> 4 files changed, 143 insertions(+), 27 deletions(-)
>
> --
> 2.20.1
>
For the series,
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2020-04-29 20:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 14:45 [PATCH bpf-next v3 0/3] tools: bpftool: probe features for unprivileged users Quentin Monnet
2020-04-29 14:45 ` [PATCH bpf-next v3 1/3] tools: bpftool: for "feature probe" define "full_mode" bool as global Quentin Monnet
2020-04-29 14:45 ` [PATCH bpf-next v3 2/3] tools: bpftool: allow unprivileged users to probe features Quentin Monnet
2020-04-29 14:45 ` [PATCH bpf-next v3 3/3] tools: bpftool: make libcap dependency optional Quentin Monnet
2020-04-29 20:10 ` John Fastabend [this message]
2020-04-29 23:14 ` [PATCH bpf-next v3 0/3] tools: bpftool: probe features for unprivileged users Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ea9df505abc3_4d8d2ae8075c45bc7d@john-XPS-13-9370.notmuch \
--to=john.fastabend@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=mtk.manpages@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).