From: Daniel Borkmann <daniel@iogearbox.net>
To: Shaun Crampton <shaun@tigera.io>
Cc: "Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
bpf@vger.kernel.org, "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 2/3] libbpf: add low level TC-BPF API
Date: Thu, 22 Apr 2021 13:26:48 +0200 [thread overview]
Message-ID: <5ee2c8e7-1ced-6103-99fa-213718bbb601@iogearbox.net> (raw)
In-Reply-To: <CAMhR0U1DRBw5AjzzLfN+bpnxsrONO_Jkr9p57yfeyCND+qMAtQ@mail.gmail.com>
On 4/22/21 11:47 AM, Shaun Crampton wrote:
>> Nope, just get it from the prog itself.
>
> Looks like the API returns the prog ID, so from that we can look up the prog
> and then get its tag? If so that meets our needs. Alternatively, if
> the API allows
> for atomic replacement of a BPF program with another, that'd also work for us.
Both is the case: from prog ID you can already retrieve that same tag, and progs
can be atomically replaced with the current API code.
Exposing the tag in here otherwise feels just odd/wrong from a design PoV, explain
that to a user of this API on /why/ such field is in the tc API when it already
can be retrieved via bpf_prog_get_info_by_fd(), as in, what is so special on this
field in the tc API here (aside from legacy reasons when there was no mentioned
helper [which we don't need to support given it dates way too far back]) ... I
cannot. ;-) Hence lets drop it from there.
Thanks,
Daniel
next prev parent reply other threads:[~2021-04-22 11:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 19:37 [PATCH bpf-next v3 0/3] Add TC-BPF API Kumar Kartikeya Dwivedi
2021-04-20 19:37 ` [PATCH bpf-next v3 1/3] libbpf: add helpers for preparing netlink attributes Kumar Kartikeya Dwivedi
2021-04-21 6:37 ` Yonghong Song
2021-04-20 19:37 ` [PATCH bpf-next v3 2/3] libbpf: add low level TC-BPF API Kumar Kartikeya Dwivedi
2021-04-21 6:58 ` Yonghong Song
2021-04-21 17:06 ` Kumar Kartikeya Dwivedi
2021-04-22 1:56 ` Yonghong Song
2021-04-21 18:19 ` Andrii Nakryiko
2021-04-21 19:48 ` Toke Høiland-Jørgensen
2021-04-21 23:14 ` Daniel Borkmann
2021-04-22 9:08 ` Toke Høiland-Jørgensen
2021-04-22 11:51 ` Daniel Borkmann
2021-04-22 12:46 ` Toke Høiland-Jørgensen
2021-04-21 22:59 ` Daniel Borkmann
2021-04-21 23:08 ` Kumar Kartikeya Dwivedi
2021-04-21 23:21 ` Daniel Borkmann
2021-04-21 23:30 ` Kumar Kartikeya Dwivedi
2021-04-21 23:41 ` Daniel Borkmann
2021-04-22 9:47 ` Shaun Crampton
2021-04-22 11:26 ` Daniel Borkmann [this message]
2021-04-22 3:43 ` Andrii Nakryiko
2021-04-22 15:35 ` Daniel Borkmann
2021-04-22 18:28 ` Andrii Nakryiko
2021-04-20 19:37 ` [PATCH bpf-next v3 3/3] libbpf: add selftests for " Kumar Kartikeya Dwivedi
2021-04-21 7:01 ` Yonghong Song
2021-04-21 18:24 ` Andrii Nakryiko
2021-04-21 19:56 ` Kumar Kartikeya Dwivedi
2021-04-21 20:38 ` Toke Høiland-Jørgensen
2021-04-21 22:41 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ee2c8e7-1ced-6103-99fa-213718bbb601@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shaun@tigera.io \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).