From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AEDAC433E0 for ; Fri, 12 Jun 2020 22:58:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E09222078A for ; Fri, 12 Jun 2020 22:58:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EbllFoiE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726304AbgFLW6R (ORCPT ); Fri, 12 Jun 2020 18:58:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbgFLW6Q (ORCPT ); Fri, 12 Jun 2020 18:58:16 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CF78C03E96F; Fri, 12 Jun 2020 15:58:15 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id x207so4995551pfc.5; Fri, 12 Jun 2020 15:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=WF0yayqOy4vitr2gfwwxeEUgwqbRugYbv4Z4Yh4JOl4=; b=EbllFoiElAHgOlHuOBsYnZw3EV7nEKET3GVw8VLabZnhR2G5qwcm0KpbXCS434NAa+ prl7pJAzOJYbKBfeY5NHA4NGBO7fRO6meV9DbBaN5L059YmK8OvR0DlWNvob/0F3uJrz APW0jeuNj1Dq4kjUj67nX37v6b5fvtNNxxk7QaXVksRLTC6b3KCQZn4VvIiUe7o2oWe9 GkYaMJMu/iyET+WA+/95mWHdbrAREXX56i3M0hQB9mbL7EiRhLcKAhMI+/UnFb1aNZsO EYr+z7PPwsfmu3ei8mwfam4SaB/eRDevBVPQtoDiv8JAuomvFvFof5u4OJHK8Qb1tgWa KxTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=WF0yayqOy4vitr2gfwwxeEUgwqbRugYbv4Z4Yh4JOl4=; b=F6gFlu6oVa4hFSxS228BsHYqSp75IlSbXL3xO2IzKDkyE0f2sXg99LqkM//jJeah+D mAU0kWIU5b/BkjPpcHo6YTqINE9ESB4OTrevVxLVPvCxx12HN9Cc+AZBekbbFT4G+vVa vNHwO+XI/U5+2mLFb0rQxJV5AqwRjn7HqzntvrE/uxk74ZAsVk86TYw//cyXAhzh3Pig +pVfYtMSVYVPAK//kN3aRNy3ng9+/G2YvkThVfQRoaymD918F/lg5TP34VyjiaqsPSOx WYslREfaw6CM/LLCE7WYBOzjxb/z5/U822VD5YaQe4JYfLw2156Ve5NHmmOu8r7U6vpI G9YQ== X-Gm-Message-State: AOAM532FtXLbvlq69VG2Hl9XWC28gydvw3hB66Wg+HnJIXgMScaJBW+0 aoYowjB8d78GE2W8b06VUSE= X-Google-Smtp-Source: ABdhPJx68gvq0ln2m7dj26qlbfcCUwPTiaCl9rQkZuvCNbCfnHJTdrkvJwpSGUzpaBRklRpCfYuAgQ== X-Received: by 2002:a62:3381:: with SMTP id z123mr14095536pfz.274.1592002695001; Fri, 12 Jun 2020 15:58:15 -0700 (PDT) Received: from localhost ([184.63.162.180]) by smtp.gmail.com with ESMTPSA id y5sm6092183pgl.85.2020.06.12.15.58.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2020 15:58:13 -0700 (PDT) Date: Fri, 12 Jun 2020 15:58:06 -0700 From: John Fastabend To: Jesper Dangaard Brouer , Gaurav Singh Cc: brouer@redhat.com, Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , KP Singh , "(open list:XDP \\(eXpress Data Path\\))" , bpf@vger.kernel.org (open list:XDP \(eXpress Data Path\)), "(open list:XDP \\(eXpress Data Path\\) open list)" Message-ID: <5ee4087e2b5a_489d2af902f845b4b7@john-XPS-13-9370.notmuch> In-Reply-To: <20200612222031.515d5338@carbon> References: <20200611150221.15665-1-gaurav1086@gmail.com> <20200612185328.4671-1-gaurav1086@gmail.com> <20200612222031.515d5338@carbon> Subject: Re: [PATCH] xdp_rxq_info_user: Fix null pointer dereference. Replace malloc/memset with calloc. Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Jesper Dangaard Brouer wrote: > On Fri, 12 Jun 2020 14:53:27 -0400 > Gaurav Singh wrote: > > > Memset on the pointer right after malloc can cause a > > null pointer deference if it failed to allocate memory. > > A simple fix is to replace malloc/memset with a calloc() > > > > Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to xdp_rxq_info") > > Signed-off-by: Gaurav Singh > > Acked-by: Jesper Dangaard Brouer > Acked-by: John Fastabend