From: John Fastabend <john.fastabend@gmail.com>
To: John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
John Fastabend <john.fastabend@gmail.com>
Cc: Andrii Nakryiko <andriin@fb.com>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 1/2] bpf: switch most helper return values from 32-bit int to 64-bit long
Date: Thu, 18 Jun 2020 17:39:29 -0700 [thread overview]
Message-ID: <5eec09418954e_27ce2adb0816a5b8f7@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <5eebf9321e11a_519a2abc9795c5bc21@john-XPS-13-9370.notmuch>
John Fastabend wrote:
> Andrii Nakryiko wrote:
> > On Thu, Jun 18, 2020 at 11:58 AM John Fastabend
> > <john.fastabend@gmail.com> wrote:
[...]
> > That would be great. Self-tests do work, but having more testing with
> > real-world application would certainly help as well.
>
> Thanks for all the follow up.
>
> I ran the change through some CI on my side and it passed so I can
> complain about a few shifts here and there or just update my code or
> just not change the return types on my side but I'm convinced its OK
> in most cases and helps in some so...
>
> Acked-by: John Fastabend <john.fastabend@gmail.com>
I'll follow this up with a few more selftests to capture a couple of our
patterns. These changes are subtle and I worry a bit that additional
<<,s>> pattern could have the potential to break something.
Another one we didn't discuss that I found in our code base is feeding
the output of a probe_* helper back into the size field (after some
alu ops) of subsequent probe_* call. Unfortunately, the tests I ran
today didn't cover that case.
I'll put it on the list tomorrow and encode these in selftests. I'll
let the mainainers decide if they want to wait for those or not.
next prev parent reply other threads:[~2020-06-19 0:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 20:21 [PATCH bpf-next 1/2] bpf: switch most helper return values from 32-bit int to 64-bit long Andrii Nakryiko
2020-06-17 20:21 ` [PATCH bpf-next 2/2] selftests/bpf: add variable-length data concatenation pattern test Andrii Nakryiko
2020-06-18 6:49 ` [PATCH bpf-next 1/2] bpf: switch most helper return values from 32-bit int to 64-bit long John Fastabend
2020-06-18 7:30 ` Andrii Nakryiko
2020-06-18 18:58 ` John Fastabend
2020-06-18 21:41 ` Andrii Nakryiko
2020-06-18 23:30 ` John Fastabend
2020-06-19 0:39 ` John Fastabend [this message]
2020-06-19 13:08 ` Daniel Borkmann
2020-06-19 18:41 ` Andrii Nakryiko
2020-06-19 22:21 ` Daniel Borkmann
2020-06-19 23:11 ` Andrii Nakryiko
2020-06-22 18:30 ` John Fastabend
2020-06-22 19:16 ` Andrii Nakryiko
2020-06-22 19:42 ` John Fastabend
2020-06-22 21:00 ` Andrii Nakryiko
2020-06-22 21:18 ` John Fastabend
2020-06-22 23:03 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eec09418954e_27ce2adb0816a5b8f7@john-XPS-13-9370.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).