From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 572A6C433E3 for ; Wed, 19 Aug 2020 20:11:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 313CF207FF for ; Wed, 19 Aug 2020 20:11:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DPsJXVrE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726868AbgHSULT (ORCPT ); Wed, 19 Aug 2020 16:11:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725275AbgHSULT (ORCPT ); Wed, 19 Aug 2020 16:11:19 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A21B5C061757; Wed, 19 Aug 2020 13:11:18 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id k13so11343168plk.13; Wed, 19 Aug 2020 13:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=dbcOzTqx7hOOJVlLikGR6xEV3IO3I5Sm2hqIIob1Cuo=; b=DPsJXVrE4wsCVAUtKsCOLb0YlLh7Om3nNkFl0FqcfsIcx8uJav/oLgVJmYsTroWpAt s9kTeMsnuX112omdMZ8Oxa024PmVMXGgYRG5cRpVUECVxsUcyN+DrJY7KFmuMYZrdG00 k0BH7UkcZ2Yaqh09IuRyJDWKUd6349jkwvc2whcHZMezjP65WV7V8dBuCTeN+XT+nl7r kKJdB0jL6lioLHwvJYzwRrthg+bEMxuDMobrRsNVFC3RwvI76mPPAAynEaDTEzT1PCLk 9CsjyIcbysz7H1fNXVH2KNd0nkYZgfSlRShswGEe528kABtIOV0g3uy0G+wQkr6rz+mw Jfvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=dbcOzTqx7hOOJVlLikGR6xEV3IO3I5Sm2hqIIob1Cuo=; b=AV4II6ZmdDZi/IcxGi4hE6vmKzmyvo0ymm+9zyqLSXFjyqHQpNR3jbyKxXG6eUPXyS B4Yu18qQ0iiEUSOr4Sf1mfTRa7GKhaUMmBIGNcQGRZbi+xMIIJa2Ku5gKCL8SM60Z87N KJOMJeQnQBjRFkZ4zBxTG6lDwdEdsuG9jPvKXu5d2a/FXcZXvSwtJUmSYy0lMr2A2C82 OhCjHV646ls1c9ysktG8e1t/R+QYwtMS3rl7N+99P5KpgD1nV/1uLSngwDxeiEFUDF19 ml+ZAw6O+ooyuEaGRlyQBVESN44UpSFtbadSApTT+ekWC8qxRlxnhM0Tc5dQojCfBD/W MKQw== X-Gm-Message-State: AOAM533eUjNru3CV0vPK+7gFw15Ss4kBIhRPMcrNqcyC7YivVnRzGyzK gIP0uK93oJz2BsPEsI1yHZ4= X-Google-Smtp-Source: ABdhPJxKb6igMqNCmJg6p6N0OwVskY/zaKIHTUPQISWCRr/ANvJg5GGLvX2ebLkFVLNRFjfXrBa5pQ== X-Received: by 2002:a17:902:8546:: with SMTP id d6mr20334128plo.218.1597867878106; Wed, 19 Aug 2020 13:11:18 -0700 (PDT) Received: from localhost ([184.63.162.180]) by smtp.gmail.com with ESMTPSA id n12sm44536pfj.99.2020.08.19.13.11.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 13:11:17 -0700 (PDT) Date: Wed, 19 Aug 2020 13:11:11 -0700 From: John Fastabend To: Lorenz Bauer , jakub@cloudflare.com, john.fastabend@gmail.com, Daniel Borkmann , Lorenz Bauer , "David S. Miller" , Jakub Kicinski , Alexei Starovoitov Cc: kernel-team@cloudflare.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <5f3d875f43b9f_2c9b2adeefb585bcea@john-XPS-13-9370.notmuch> In-Reply-To: <20200819092436.58232-3-lmb@cloudflare.com> References: <20200819092436.58232-1-lmb@cloudflare.com> <20200819092436.58232-3-lmb@cloudflare.com> Subject: RE: [PATCH bpf-next 2/6] bpf: sockmap: merge sockmap and sockhash update functions Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Lorenz Bauer wrote: > Merge the two very similar functions sock_map_update_elem and > sock_hash_update_elem into one. > > Signed-off-by: Lorenz Bauer > --- > net/core/sock_map.c | 53 ++++++++------------------------------------- > 1 file changed, 9 insertions(+), 44 deletions(-) > Fixup the warning, but otherwise Acked-by: John Fastabend