BPF Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH bpf 0/3] Devmap fixes around memory and RCU
@ 2019-06-14  8:20 Toshiaki Makita
  2019-06-14  8:20 ` [PATCH bpf 1/3] devmap: Fix premature entry free on destroying map Toshiaki Makita
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Toshiaki Makita @ 2019-06-14  8:20 UTC (permalink / raw)
  To: Alexei Starovoitov, Daniel Borkmann, David S. Miller,
	Jakub Kicinski, Jesper Dangaard Brouer, John Fastabend
  Cc: Toshiaki Makita, netdev, xdp-newbies, bpf, Michael S. Tsirkin,
	Jason Wang, David Ahern

Patch1: Jesper showed concerns around devmap free and flush race when
    reviewing my XDP bulk TX patch set, and I think indeed there is a
    race. Patch1 fix it.

Patch2: While reviewing dev_map_free I found bulk queue was not freed.
    Patch2 fix it.

Patch3: Some days ago David Ahern reported suspicous RCU usage in
    virtnet_xdp_xmit(), but it seems no one posted an official fix
    patch. So I arraged the fix.

Signed-off-by: Toshiaki Makita <toshiaki.makita1@gmail.com>

Toshiaki Makita (3):
  devmap: Fix premature entry free on destroying map
  devmap: Add missing bulk queue free
  devmap: Add missing RCU read lock on flush

 kernel/bpf/devmap.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, back to index

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14  8:20 [PATCH bpf 0/3] Devmap fixes around memory and RCU Toshiaki Makita
2019-06-14  8:20 ` [PATCH bpf 1/3] devmap: Fix premature entry free on destroying map Toshiaki Makita
2019-06-14 11:04   ` Toke Høiland-Jørgensen
2019-06-14 12:10     ` Toke Høiland-Jørgensen
2019-06-14 12:59       ` Toshiaki Makita
2019-06-14 13:09         ` Toke Høiland-Jørgensen
2019-06-14 23:07           ` Daniel Borkmann
2019-06-15 10:10             ` Toke Høiland-Jørgensen
2019-06-14 12:20     ` Jesper Dangaard Brouer
2019-06-14  8:20 ` [PATCH bpf 2/3] devmap: Add missing bulk queue free Toshiaki Makita
2019-06-14 11:58   ` Jesper Dangaard Brouer
2019-06-14 13:03     ` Toshiaki Makita
2019-06-14  8:20 ` [PATCH bpf 3/3] devmap: Add missing RCU read lock on flush Toshiaki Makita
2019-06-14 11:07   ` Toke Høiland-Jørgensen

BPF Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \
		bpf@vger.kernel.org bpf@archiver.kernel.org
	public-inbox-index bpf


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.bpf


AGPL code for this site: git clone https://public-inbox.org/ public-inbox