From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA64C433ED for ; Wed, 28 Apr 2021 10:49:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 219C361429 for ; Wed, 28 Apr 2021 10:49:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238959AbhD1Kty (ORCPT ); Wed, 28 Apr 2021 06:49:54 -0400 Received: from www62.your-server.de ([213.133.104.62]:47648 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238640AbhD1Ktx (ORCPT ); Wed, 28 Apr 2021 06:49:53 -0400 Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1lbhki-0000Q7-Ae; Wed, 28 Apr 2021 12:49:08 +0200 Received: from [85.7.101.30] (helo=linux.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbhki-000SS2-6u; Wed, 28 Apr 2021 12:49:08 +0200 Subject: Re: [PATCH bpf 2/2] selftests/bpf: Add test for bpf_skb_change_head To: Jussi Maki , Andrii Nakryiko Cc: bpf References: <20210427135550.807355-1-joamaki@gmail.com> <20210427135550.807355-2-joamaki@gmail.com> From: Daniel Borkmann Message-ID: <5f7259ab-05a5-1e30-a87e-6ae5672c50f1@iogearbox.net> Date: Wed, 28 Apr 2021 12:49:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.2/26153/Tue Apr 27 13:09:27 2021) Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 4/28/21 12:39 PM, Jussi Maki wrote: > On Tue, Apr 27, 2021 at 11:41 PM Andrii Nakryiko > wrote: >>> ... >>> +test_tc_peer_user >> >> can we make it into a reasonable test inside test_progs? that way it >> will be executed regularly > > There doesn't seem to be any tests yet for redirect_peer in test_progs and I'd > like this test to live next to them. Would it make sense to rework > test_tc_redirect.sh > into the test_progs framework? > > What's your thoughts on this Daniel? Yes, please, that would be awesome to have test_tc_redirect.sh reworked to run as part of test_progs! :) Then it will be covered by CI [0]. Thanks, Daniel [0] https://travis-ci.com/github/kernel-patches/bpf/pull_requests