From: John Fastabend <john.fastabend@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>,
John Fastabend <john.fastabend@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>,
duanxiongchun@bytedance.com,
Dongdong Wang <wangdongdong.6@bytedance.com>,
Jiang Wang <jiang.wang@bytedance.com>,
Cong Wang <cong.wang@bytedance.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Jakub Sitnicki <jakub@cloudflare.com>,
Lorenz Bauer <lmb@cloudflare.com>
Subject: Re: [Patch bpf-next v4 4/5] skmsg: move sk_redir from TCP_SKB_CB to skb
Date: Wed, 17 Feb 2021 12:12:43 -0800 [thread overview]
Message-ID: <602d78bbd1218_ddd220893@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <CAM_iQpXBC49FBAf2LLANz94OFnVKoJADc9yePJBUuvMARbfq7w@mail.gmail.com>
Cong Wang wrote:
> On Wed, Feb 17, 2021 at 10:40 AM John Fastabend
> <john.fastabend@gmail.com> wrote:
> > > @@ -802,9 +809,10 @@ int sk_psock_tls_strp_read(struct sk_psock *psock, struct sk_buff *skb)
> > > * TLS context.
> > > */
> > > skb->sk = psock->sk;
> > > - tcp_skb_bpf_redirect_clear(skb);
> > > + skb_dst_drop(skb);
> > > + skb_bpf_redirect_clear(skb);
> >
> > Do we really need the skb_dst_drop() I thought we would have already dropped this here
> > but I've not had time to check yet.
>
> Yes, I got some serious complaints from dst_release() when I didn't
> add skb_dst_drop().
>
> Thanks.
OK thanks.
next prev parent reply other threads:[~2021-02-17 20:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 6:42 [Patch bpf-next v4 0/5] sock_map: clean up and refactor code for BPF_SK_SKB_VERDICT Cong Wang
2021-02-16 6:42 ` [Patch bpf-next v4 1/5] bpf: clean up sockmap related Kconfigs Cong Wang
2021-02-19 18:25 ` Jakub Sitnicki
2021-02-19 18:46 ` Cong Wang
2021-02-19 22:00 ` Jakub Sitnicki
2021-02-16 6:42 ` [Patch bpf-next v4 2/5] skmsg: get rid of struct sk_psock_parser Cong Wang
2021-02-16 6:42 ` [Patch bpf-next v4 3/5] bpf: compute data_end dynamically with JIT code Cong Wang
2021-02-16 6:42 ` [Patch bpf-next v4 4/5] skmsg: move sk_redir from TCP_SKB_CB to skb Cong Wang
2021-02-17 18:40 ` John Fastabend
2021-02-17 18:49 ` Cong Wang
2021-02-17 20:12 ` John Fastabend [this message]
2021-02-16 6:42 ` [Patch bpf-next v4 5/5] sock_map: rename skb_parser and skb_verdict Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=602d78bbd1218_ddd220893@john-XPS-13-9370.notmuch \
--to=john.fastabend@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=duanxiongchun@bytedance.com \
--cc=jakub@cloudflare.com \
--cc=jiang.wang@bytedance.com \
--cc=lmb@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=wangdongdong.6@bytedance.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).