From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B52AEC433DB for ; Wed, 17 Feb 2021 20:13:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8704A64E6C for ; Wed, 17 Feb 2021 20:13:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233490AbhBQUNc (ORCPT ); Wed, 17 Feb 2021 15:13:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233332AbhBQUNb (ORCPT ); Wed, 17 Feb 2021 15:13:31 -0500 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF347C061574; Wed, 17 Feb 2021 12:12:50 -0800 (PST) Received: by mail-io1-xd32.google.com with SMTP id q77so3153699iod.2; Wed, 17 Feb 2021 12:12:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=xD3xqmZLKLFl8D9bl6zOVotN7gOhOOlYP72KjDNrvlI=; b=CxnYjEoBwZGe65kabYHjpetsnAu2LY+1d5CVBjgl71Jx4FuCOpb+8CCYD8DVpC5GXQ ghlHs9NXk3yrmfq8ReMmuVjYVKMp2ybvNl3vNgG4XYvV1KGo93NCP6nuE+MI0rOxLLku DKbzbnX2q+K0Pm86He/e+sXYWdKTL8Lspuf8HkiOP0A4Lx0ohTjxDg9BFPGcBR2Zq4Of JatOWg4yUHj58X47vyBwBm9TMAIzX13TyBYsGZYdVcfVUpmSIh52XytwCUKr5AiudgJl 2buU3sZaqL4qP5ZaLJhzLBEmTtH/lkArbIKyb5vBUsLu8cn+Rn/xhXfjDaG9VOpQizJQ YUDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=xD3xqmZLKLFl8D9bl6zOVotN7gOhOOlYP72KjDNrvlI=; b=YJYxmST1b3UveLQpxhEtlni3RO9GKLWPh5e2Ke/OFVN4mi4j+siso7emStQKkyexCF mEpnxkiKaisKr0Aylj8HC6ZWh+9p4bx594fvc5Cfh9ejv9MXlXsgMoofLauoCWFjWibn xSvfR6GQs7yY1+xW+Lfid3sLUa8sDwm9ObI30N+KE75k0O9aaBMVTVIhvBhIlZ3OxgLH 6eBgxUdCBVJeT71MRMDvczDgPwjVh0TbHidWnwZvg+noqVpipLbttv09gOmvIULmOmzh sTsbJyWo3QE+DsNXuzwXduYGEX21H4t1F0JXtzJ+P8qZ0ekI+CO/JLfMVARxtDRLWyyV 9Udw== X-Gm-Message-State: AOAM531nMm2svx0cXNY/cTX7OdgzPqDIljgh5xME67XdYmi9qGwy3Br3 jsFzpbsmtNBTigP/gNHD058= X-Google-Smtp-Source: ABdhPJyia5iYEHFKA/xe4637mg/PzIJ5YYbLvKBeQNKo3T0NUe1KQvdl4xnth60IUlzHgbbyM0d1bw== X-Received: by 2002:a6b:3b14:: with SMTP id i20mr702579ioa.28.1613592770253; Wed, 17 Feb 2021 12:12:50 -0800 (PST) Received: from localhost ([172.243.146.206]) by smtp.gmail.com with ESMTPSA id b8sm2039978iow.44.2021.02.17.12.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 12:12:49 -0800 (PST) Date: Wed, 17 Feb 2021 12:12:43 -0800 From: John Fastabend To: Cong Wang , John Fastabend Cc: Linux Kernel Network Developers , bpf , duanxiongchun@bytedance.com, Dongdong Wang , Jiang Wang , Cong Wang , Daniel Borkmann , Jakub Sitnicki , Lorenz Bauer Message-ID: <602d78bbd1218_ddd220893@john-XPS-13-9370.notmuch> In-Reply-To: References: <20210216064250.38331-1-xiyou.wangcong@gmail.com> <20210216064250.38331-5-xiyou.wangcong@gmail.com> <602d631877e40_aed9208bc@john-XPS-13-9370.notmuch> Subject: Re: [Patch bpf-next v4 4/5] skmsg: move sk_redir from TCP_SKB_CB to skb Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Cong Wang wrote: > On Wed, Feb 17, 2021 at 10:40 AM John Fastabend > wrote: > > > @@ -802,9 +809,10 @@ int sk_psock_tls_strp_read(struct sk_psock *psock, struct sk_buff *skb) > > > * TLS context. > > > */ > > > skb->sk = psock->sk; > > > - tcp_skb_bpf_redirect_clear(skb); > > > + skb_dst_drop(skb); > > > + skb_bpf_redirect_clear(skb); > > > > Do we really need the skb_dst_drop() I thought we would have already dropped this here > > but I've not had time to check yet. > > Yes, I got some serious complaints from dst_release() when I didn't > add skb_dst_drop(). > > Thanks. OK thanks.