* [Patch bpf-next] udp_bpf: remove some pointless comments
@ 2021-04-03 5:27 Cong Wang
2021-04-05 20:39 ` John Fastabend
2021-04-06 21:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Cong Wang @ 2021-04-03 5:27 UTC (permalink / raw)
To: netdev
Cc: bpf, Cong Wang, Jakub Sitnicki, John Fastabend, Daniel Borkmann,
Lorenz Bauer
From: Cong Wang <cong.wang@bytedance.com>
These comments in udp_bpf_update_proto() are copied from the
original TCP code and apparently do not apply to UDP. Just
remove them.
Reported-by: Jakub Sitnicki <jakub@cloudflare.com>
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Lorenz Bauer <lmb@cloudflare.com>
Signed-off-by: Cong Wang <cong.wang@bytedance.com>
---
net/ipv4/udp_bpf.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/ipv4/udp_bpf.c b/net/ipv4/udp_bpf.c
index 7d5c4ebf42fe..4a7e38c5d842 100644
--- a/net/ipv4/udp_bpf.c
+++ b/net/ipv4/udp_bpf.c
@@ -110,7 +110,6 @@ int udp_bpf_update_proto(struct sock *sk, bool restore)
if (restore) {
sk->sk_write_space = psock->saved_write_space;
- /* Pairs with lockless read in sk_clone_lock() */
WRITE_ONCE(sk->sk_prot, psock->sk_proto);
return 0;
}
@@ -118,7 +117,6 @@ int udp_bpf_update_proto(struct sock *sk, bool restore)
if (sk->sk_family == AF_INET6)
udp_bpf_check_v6_needs_rebuild(psock->sk_proto);
- /* Pairs with lockless read in sk_clone_lock() */
WRITE_ONCE(sk->sk_prot, &udp_bpf_prots[family]);
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [Patch bpf-next] udp_bpf: remove some pointless comments
2021-04-03 5:27 [Patch bpf-next] udp_bpf: remove some pointless comments Cong Wang
@ 2021-04-05 20:39 ` John Fastabend
2021-04-06 21:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: John Fastabend @ 2021-04-05 20:39 UTC (permalink / raw)
To: Cong Wang, netdev
Cc: bpf, Cong Wang, Jakub Sitnicki, John Fastabend, Daniel Borkmann,
Lorenz Bauer
Cong Wang wrote:
> From: Cong Wang <cong.wang@bytedance.com>
>
> These comments in udp_bpf_update_proto() are copied from the
> original TCP code and apparently do not apply to UDP. Just
> remove them.
>
> Reported-by: Jakub Sitnicki <jakub@cloudflare.com>
> Cc: John Fastabend <john.fastabend@gmail.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Lorenz Bauer <lmb@cloudflare.com>
> Signed-off-by: Cong Wang <cong.wang@bytedance.com>
> ---
Acked-by: John Fastabend <john.fastabend@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch bpf-next] udp_bpf: remove some pointless comments
2021-04-03 5:27 [Patch bpf-next] udp_bpf: remove some pointless comments Cong Wang
2021-04-05 20:39 ` John Fastabend
@ 2021-04-06 21:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-06 21:30 UTC (permalink / raw)
To: Cong Wang; +Cc: netdev, bpf, cong.wang, jakub, john.fastabend, daniel, lmb
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Fri, 2 Apr 2021 22:27:15 -0700 you wrote:
> From: Cong Wang <cong.wang@bytedance.com>
>
> These comments in udp_bpf_update_proto() are copied from the
> original TCP code and apparently do not apply to UDP. Just
> remove them.
>
> Reported-by: Jakub Sitnicki <jakub@cloudflare.com>
> Cc: John Fastabend <john.fastabend@gmail.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Lorenz Bauer <lmb@cloudflare.com>
> Signed-off-by: Cong Wang <cong.wang@bytedance.com>
>
> [...]
Here is the summary with links:
- [bpf-next] udp_bpf: remove some pointless comments
https://git.kernel.org/bpf/bpf-next/c/928dc406802d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-06 21:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-03 5:27 [Patch bpf-next] udp_bpf: remove some pointless comments Cong Wang
2021-04-05 20:39 ` John Fastabend
2021-04-06 21:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).