From: Song Liu <songliubraving@fb.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Song Liu <song@kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"andrii@kernel.org" <andrii@kernel.org>,
Kernel Team <Kernel-team@fb.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>,
"rick.p.edgecombe@intel.com" <rick.p.edgecombe@intel.com>
Subject: Re: [PATCH bpf 3/4] x86: select HAVE_ARCH_HUGE_VMALLOC_FLAG for X86_64
Date: Thu, 31 Mar 2022 00:30:39 +0000 [thread overview]
Message-ID: <66367845-0FB5-499A-B0E6-93A3209FE1CE@fb.com> (raw)
In-Reply-To: <87tubfm1wv.ffs@tglx>
> On Mar 30, 2022, at 4:54 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Wed, Mar 30 2022 at 15:56, Song Liu wrote:
>> As HAVE_ARCH_HUGE_VMALLOC is not ready for X86_64, enable
>> HAVE_ARCH_HUGE_VMALLOC_FLAG to allow bpf_prog_pack to allocate huge
>> pages.
>
> Despite HAVE_ARCH_HUGE_VMALLOC being not ready for X86_64 enable it
> nevertheless?
These are two different flags:
HAVE_ARCH_HUGE_VMALLOC allows vmalloc to try to allocate huge pages for
size >= PMD_SIZE, unless it is disabled with nohugeiomap or VM_NO_HUGE_VMAP.
HAVE_ARCH_HUGE_VMALLOC_FLAG allows vmalloc to try to allocate huge pages
for size >= PMD_SIZE, only when the user specifies VM_TRY_HUGE_VMAP.
Recommendations for better naming will be highly appreciated..
Song
>
> I assume you wanted to say something like this:
>
> The shortcomings of huge vmalloc allocations have been fixed in the
> memory management core code, so reenable HAVE_ARCH_HUGE_VMALLOC.
>
> Thanks,
>
> tglx
next prev parent reply other threads:[~2022-03-31 0:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220330225642.1163897-1-song@kernel.org>
[not found] ` <20220330225642.1163897-3-song@kernel.org>
2022-03-30 23:40 ` [PATCH bpf 2/4] vmalloc: introduce HAVE_ARCH_HUGE_VMALLOC_FLAG Edgecombe, Rick P
2022-03-31 0:26 ` Song Liu
[not found] ` <20220330225642.1163897-2-song@kernel.org>
2022-03-30 23:47 ` [PATCH bpf 1/4] x86: disable HAVE_ARCH_HUGE_VMALLOC Thomas Gleixner
[not found] ` <20220330225642.1163897-4-song@kernel.org>
2022-03-30 23:54 ` [PATCH bpf 3/4] x86: select HAVE_ARCH_HUGE_VMALLOC_FLAG for X86_64 Thomas Gleixner
2022-03-31 0:30 ` Song Liu [this message]
[not found] ` <20220330225642.1163897-5-song@kernel.org>
2022-03-31 0:00 ` [PATCH bpf 4/4] bpf: use __vmalloc_node_range() with VM_TRY_HUGE_VMAP for bpf_prog_pack Thomas Gleixner
2022-03-31 0:31 ` Song Liu
2022-03-31 0:04 ` [PATCH bpf 0/4] introduce HAVE_ARCH_HUGE_VMALLOC_FLAG " Edgecombe, Rick P
2022-03-31 0:46 ` Song Liu
2022-03-31 16:19 ` Edgecombe, Rick P
2022-03-31 5:37 ` Christoph Hellwig
2022-03-31 23:59 ` Song Liu
2022-04-01 22:22 ` Song Liu
2022-04-05 7:07 ` Christoph Hellwig
2022-04-05 23:54 ` Song Liu
2022-04-07 19:57 ` Song Liu
2022-04-08 10:08 ` Claudio Imbrenda
2022-04-08 21:22 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66367845-0FB5-499A-B0E6-93A3209FE1CE@fb.com \
--to=songliubraving@fb.com \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=rick.p.edgecombe@intel.com \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).