bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andriin@fb.com>
To: Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	Yonghong Song <yhs@fb.com>, Martin Lau <kafai@fb.com>,
	Jakub Kicinski <jakub.kicinski@netronome.com>,
	"andrii.nakryiko@gmail.com" <andrii.nakryiko@gmail.com>
Subject: Re: [PATCH] bpftool: Allow to read btf as raw data
Date: Fri, 25 Oct 2019 05:10:31 +0000	[thread overview]
Message-ID: <69f99d56-4738-5e94-4bf5-73b60fe03312@fb.com> (raw)
In-Reply-To: <20191024133025.10691-1-jolsa@kernel.org>

On 10/24/19 6:30 AM, Jiri Olsa wrote:
> The bpftool interface stays the same, but now it's possible
> to run it over BTF raw data, like:
> 
>    $ bpftool btf dump file /sys/kernel/btf/vmlinux
>    [1] INT '(anon)' size=4 bits_offset=0 nr_bits=32 encoding=(none)
>    [2] INT 'long unsigned int' size=8 bits_offset=0 nr_bits=64 encoding=(none)
>    [3] CONST '(anon)' type_id=2
> 
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> v3 changes:
>   - fix title

The subject (by now) should be "[PATCH v3 bpf-next] ...". Include both 
version and intended tree (bpf-next usually).

> 
> v2 changes:
>   - added is_btf_raw to find out which btf__parse_* function to call
>   - changed labels and error propagation in btf__parse_raw
>   - drop the err initialization, which is not needed under this change
> 
>   tools/bpf/bpftool/btf.c | 57 ++++++++++++++++++++++++++++++++++++++++-
>   1 file changed, 56 insertions(+), 1 deletion(-)
> 


Overall looks good. It's kind of sad that we re-open that file twice, 
but we can optimize that later, if it ever is a problem. We should 
probably eventually implement btf__parse_raw as libbpf API with mmap2().
But perfect is the enemy of the good, so:

Acked-by: Andrii Nakryiko <andriin@fb.com>

> diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c
> index 9a9376d1d3df..a7b8bf233cf5 100644
> --- a/tools/bpf/bpftool/btf.c
> +++ b/tools/bpf/bpftool/btf.c
> @@ -12,6 +12,9 @@

[...]


  parent reply	other threads:[~2019-10-25  5:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 13:30 Jiri Olsa
2019-10-24 17:55 ` Jakub Kicinski
2019-10-25  7:15   ` Jiri Olsa
2019-10-25  5:10 ` Andrii Nakryiko [this message]
2019-10-25 18:39 ` Jakub Kicinski
2019-10-25 20:03   ` Jiri Olsa
2019-10-26 18:42     ` Jakub Kicinski
2019-10-25 21:40 ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69f99d56-4738-5e94-4bf5-73b60fe03312@fb.com \
    --to=andriin@fb.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=jolsa@kernel.org \
    --cc=kafai@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=yhs@fb.com \
    --subject='Re: [PATCH] bpftool: Allow to read btf as raw data' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).