bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <ast@fb.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
	Network Development <netdev@vger.kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v3 bpf-next 0/7] libbpf: add support for kernel module BTF CO-RE relocations
Date: Tue, 1 Dec 2020 14:22:25 -0800	[thread overview]
Message-ID: <728b74ef-70c6-0031-fefa-804e290bdb0b@fb.com> (raw)
In-Reply-To: <CAEf4BzZAS71B6AQk2WCLA3d_vtsyYrA5bYT4YF0Wz7H=0XP8Fw@mail.gmail.com>

On 12/1/20 1:49 PM, Andrii Nakryiko wrote:
> On Tue, Dec 1, 2020 at 1:30 PM Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:
>>
>> On Mon, Nov 30, 2020 at 7:49 PM Andrii Nakryiko <andrii@kernel.org> wrote:
>>>
>>> Implement libbpf support for performing CO-RE relocations against types in
>>> kernel module BTFs, in addition to existing vmlinux BTF support.
>>>
>>> This is a first step towards fully supporting kernel module BTFs. Subsequent
>>> patch sets will expand kernel and libbpf sides to allow using other
>>> BTF-powered capabilities (fentry/fexit, struct_ops, ksym externs, etc). For
>>> CO-RE relocations support, though, no extra kernel changes are necessary.
>>>
>>> This patch set also sets up a convenient and fully-controlled custom kernel
>>> module (called "bpf_testmod"), that is a predictable playground for all the
>>> BPF selftests, that rely on module BTFs.
>>>
>>> v2->v3:
>>>    - fix subtle uninitialized variable use in BTF ID iteration code;
>>
>> While testing this patch I've hit this:
> 
> Right, I ran into that while testing the second patch set
> (fexit/fentry one), and fixed in patch "bpf: keep module's
> btf_data_size intact after load". But I've mistakenly added it to the
> second patch set, not to this one, my bad. I'll move it into this one.
> Or maybe I should just combine those two now for easier logistics?

whichever way. Combining is fine by me, since I've looked at both sets 
already.

      reply	other threads:[~2020-12-01 22:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01  3:47 [PATCH v3 bpf-next 0/7] libbpf: add support for kernel module BTF CO-RE relocations Andrii Nakryiko
2020-12-01  3:47 ` [PATCH v3 bpf-next 1/7] bpf: fix bpf_put_raw_tracepoint()'s use of __module_address() Andrii Nakryiko
2020-12-01  3:47 ` [PATCH v3 bpf-next 2/7] libbpf: add internal helper to load BTF data by FD Andrii Nakryiko
2020-12-01  3:47 ` [PATCH v3 bpf-next 3/7] libbpf: refactor CO-RE relocs to not assume a single BTF object Andrii Nakryiko
2020-12-01  3:47 ` [PATCH v3 bpf-next 4/7] libbpf: add kernel module BTF support for CO-RE relocations Andrii Nakryiko
2020-12-01  3:47 ` [PATCH v3 bpf-next 5/7] selftests/bpf: add bpf_testmod kernel module for testing Andrii Nakryiko
2020-12-01  3:47 ` [PATCH v3 bpf-next 6/7] selftests/bpf: add support for marking sub-tests as skipped Andrii Nakryiko
2020-12-01  3:47 ` [PATCH v3 bpf-next 7/7] selftests/bpf: add CO-RE relocs selftest relying on kernel module BTF Andrii Nakryiko
2020-12-01 21:29 ` [PATCH v3 bpf-next 0/7] libbpf: add support for kernel module BTF CO-RE relocations Alexei Starovoitov
2020-12-01 21:49   ` Andrii Nakryiko
2020-12-01 22:22     ` Alexei Starovoitov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=728b74ef-70c6-0031-fefa-804e290bdb0b@fb.com \
    --to=ast@fb.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).