From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net
Cc: kernel-team@fb.com, "Kenta Tada" <Kenta.Tada@sony.com>,
"Hengqi Chen" <hengqi.chen@gmail.com>,
"Björn Töpel" <bjorn@kernel.org>
Subject: Re: [PATCH bpf-next 1/2] libbpf: normalize PT_REGS_xxx() macro definitions
Date: Thu, 23 Dec 2021 02:26:04 +0100 [thread overview]
Message-ID: <72ef381f2aa0b8bf20a07052b71eb7ad1f426c86.camel@linux.ibm.com> (raw)
In-Reply-To: <20211222213924.1869758-1-andrii@kernel.org>
On Wed, 2021-12-22 at 13:39 -0800, Andrii Nakryiko wrote:
> Refactor PT_REGS macros definitions in bpf_tracing.h to avoid
> excessive
> duplication. We currently have classic PT_REGS_xxx() and CO-RE-
> enabled
> PT_REGS_xxx_CORE(). We are about to add also _SYSCALL variants, which
> would require excessive copying of all the per-architecture
> definitions.
>
> Instead, separate architecture-specific field/register names from the
> final macro that utilize them. That way for upcoming _SYSCALL
> variants
> we'll be able to just define x86_64 exception and otherwise have one
> common set of _SYSCALL macro definitions common for all
> architectures.
>
> Cc: Kenta Tada <Kenta.Tada@sony.com>
> Cc: Hengqi Chen <hengqi.chen@gmail.com>
> Cc: Björn Töpel <bjorn@kernel.org>
> Cc: Ilya Leoshkevich <iii@linux.ibm.com>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
> ---
> tools/lib/bpf/bpf_tracing.h | 377 +++++++++++++++-------------------
> --
> 1 file changed, 152 insertions(+), 225 deletions(-)
Works fine on s390, and looks good to me.
For both patches:
Tested-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
Best regards,
Ilya
next prev parent reply other threads:[~2021-12-23 1:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 21:39 [PATCH bpf-next 1/2] libbpf: normalize PT_REGS_xxx() macro definitions Andrii Nakryiko
2021-12-22 21:39 ` [PATCH bpf-next 2/2] libbpf: use 100-character limit to make bpf_tracing.h easier to read Andrii Nakryiko
2021-12-23 0:27 ` Yonghong Song
2021-12-22 21:50 ` [PATCH bpf-next 1/2] libbpf: normalize PT_REGS_xxx() macro definitions Andrii Nakryiko
2021-12-23 0:26 ` Yonghong Song
2021-12-23 0:34 ` Andrii Nakryiko
2021-12-23 1:26 ` Ilya Leoshkevich [this message]
2021-12-29 3:32 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72ef381f2aa0b8bf20a07052b71eb7ad1f426c86.camel@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=Kenta.Tada@sony.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hengqi.chen@gmail.com \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).