From: Daniel Borkmann <daniel@iogearbox.net>
To: Andrii Nakryiko <andriin@fb.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com
Cc: andrii.nakryiko@gmail.com, kernel-team@fb.com
Subject: Re: [PATCH bpf-next 1/2] tools/bpftool: allow substituting custom vmlinux.h for the build
Date: Tue, 30 Jun 2020 16:12:00 +0200 [thread overview]
Message-ID: <74b531fe-d55c-7698-4a13-8119793c5edc@iogearbox.net> (raw)
In-Reply-To: <20200630004759.521530-1-andriin@fb.com>
On 6/30/20 2:47 AM, Andrii Nakryiko wrote:
> In some build contexts (e.g., Travis CI build for outdated kernel), vmlinux.h,
> generated from available kernel, doesn't contain all the types necessary for
> BPF program compilation. For such set up, the most maintainable way to deal
> with this problem is to keep pre-generated (almost up-to-date) vmlinux.h
> checked in and use it for compilation purposes. bpftool after that can deal
> with kernel missing some of the features in runtime with no problems.
>
> To that effect, allow to specify path to custom vmlinux.h to bpftool's
> Makefile with VMLINUX_H variable.
>
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Both applied, thanks!
prev parent reply other threads:[~2020-06-30 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 0:47 [PATCH bpf-next 1/2] tools/bpftool: allow substituting custom vmlinux.h for the build Andrii Nakryiko
2020-06-30 0:47 ` [PATCH bpf-next 2/2] selftests/bpf: allow substituting custom vmlinux.h for selftests build Andrii Nakryiko
2020-06-30 4:51 ` Yonghong Song
2020-06-30 3:12 ` [PATCH bpf-next 1/2] tools/bpftool: allow substituting custom vmlinux.h for the build Yonghong Song
2020-06-30 14:12 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74b531fe-d55c-7698-4a13-8119793c5edc@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).