From: Daniel Borkmann <daniel@iogearbox.net>
To: Miklos Szeredi <miklos@szeredi.hu>, Lorenz Bauer <lmb@cloudflare.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Miklos Szeredi <mszeredi@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
network dev <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Christian Brauner <christian@brauner.io>
Subject: Re: [PATCH bpf-next v3 2/4] libfs: support RENAME_EXCHANGE in simple_rename()
Date: Tue, 2 Nov 2021 11:11:02 +0100 [thread overview]
Message-ID: <7988de27-1718-60c1-ec03-9343d2cc460f@iogearbox.net> (raw)
In-Reply-To: <CAJfpegvPrQBnYO3XNcCHODBBCXm6uH73zOWXs+sfn=3LQmMyww@mail.gmail.com>
On 11/2/21 10:25 AM, Miklos Szeredi wrote:
> On Thu, 28 Oct 2021 at 11:48, Lorenz Bauer <lmb@cloudflare.com> wrote:
>>
>> Allow atomic exchange via RENAME_EXCHANGE when using simple_rename.
>> This affects binderfs, ramfs, hubetlbfs and bpffs.
>
> Ramfs and hugetlbfs are generic enough; those seem safe.
>
> Binderfs: I have no idea what this does; binderfs_rename() should
> probably error out on RENAME_EXCHANGE for now, or an explicit ack from
> the maintainers.
Thanks for the review, Miklos! Adding Christian to Cc wrt binderfs ... full context
for all patches: https://lore.kernel.org/bpf/20211028094724.59043-1-lmb@cloudflare.com/
> Bpffs is your baby...
>
> Thanks,
> Miklos
>
next prev parent reply other threads:[~2021-11-02 10:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 9:47 [PATCH bpf-next v3 0/4] Support RENAME_EXCHANGE on bpffs Lorenz Bauer
2021-10-28 9:47 ` [PATCH bpf-next v3 1/4] libfs: move shmem_exchange to simple_rename_exchange Lorenz Bauer
2021-10-29 15:28 ` Daniel Borkmann
2021-11-02 8:58 ` Miklos Szeredi
2021-10-28 9:47 ` [PATCH bpf-next v3 2/4] libfs: support RENAME_EXCHANGE in simple_rename() Lorenz Bauer
2021-11-02 9:25 ` Miklos Szeredi
2021-11-02 10:11 ` Daniel Borkmann [this message]
2021-11-02 11:36 ` Christian Brauner
2021-10-28 9:47 ` [PATCH bpf-next v3 3/4] selftests: bpf: convert test_bpffs to ASSERT macros Lorenz Bauer
2021-10-28 9:47 ` [PATCH bpf-next v3 4/4] selftests: bpf: test RENAME_EXCHANGE and RENAME_NOREPLACE on bpffs Lorenz Bauer
2021-11-03 15:00 ` [PATCH bpf-next v3 0/4] Support RENAME_EXCHANGE " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7988de27-1718-60c1-ec03-9343d2cc460f@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=christian@brauner.io \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lmb@cloudflare.com \
--cc=miklos@szeredi.hu \
--cc=mszeredi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).