From: Yonghong Song <yhs@fb.com>
To: Jean-Philippe Menil <jpmenil@gmail.com>
Cc: <netdev@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Andrii Nakryiko <andriin@fb.com>, <bpf@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bpf: fix build warning - missing prototype
Date: Mon, 23 Mar 2020 07:52:00 -0700 [thread overview]
Message-ID: <7c27e51f-6a64-7374-b705-450cad42146c@fb.com> (raw)
In-Reply-To: <20200323074247.wdkfualyvf3n6vlo@macbook>
On 3/23/20 12:42 AM, Jean-Philippe Menil wrote:
> On 22/03/20 at 10:32pm, Yonghong Song wrote:
>>
>>
>> On 3/22/20 7:08 AM, Jean-Philippe Menil wrote:
>>> Fix build warning when building net/bpf/test_run.o with W=1 due
>>> to missing prototype for bpf_fentry_test{1..6}.
>>>
>>> These functions are only used in test_run.c so just make them static.
>>> Therefore inline keyword should sit between storage class and type.
>>
>> This won't work. These functions are intentionally global functions
>> so that their definitions will be in vmlinux BTF and fentry/fexit kernel
>> selftests can run against them.
>>
>> See file
>> linux/tools/testing/selftests/bpf/progs/{fentry_test.c,fexit_test.c}.
>>
>
> I can see now, thanks for the pointer.
> I totally missed that.
>
> So, in order to fix the warnings, better to declare the prototypes?
> (compiling with W=1 may be a bit unusual).
Right, you can add prototypes in the same file (test_run.c) to silence
the warning.
>
>>>
>>> Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com>
>>> ---
>>> net/bpf/test_run.c | 12 ++++++------
>>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c
>>> index d555c0d8657d..c0dcd29f682c 100644
>>> --- a/net/bpf/test_run.c
>>> +++ b/net/bpf/test_run.c
>>> @@ -113,32 +113,32 @@ static int bpf_test_finish(const union bpf_attr
>>> *kattr,
>>> * architecture dependent calling conventions. 7+ can be supported
>>> in the
>>> * future.
>>> */
>>> -int noinline bpf_fentry_test1(int a)
>>> +static noinline int bpf_fentry_test1(int a)
>>> {
>>> return a + 1;
>>> }
>>> -int noinline bpf_fentry_test2(int a, u64 b)
>>> +static noinline int bpf_fentry_test2(int a, u64 b)
>>> {
>>> return a + b;
>>> }
>>> -int noinline bpf_fentry_test3(char a, int b, u64 c)
>>> +static noinline int bpf_fentry_test3(char a, int b, u64 c)
>>> {
>>> return a + b + c;
>>> }
>>> -int noinline bpf_fentry_test4(void *a, char b, int c, u64 d)
>>> +static noinline int bpf_fentry_test4(void *a, char b, int c, u64 d)
>>> {
>>> return (long)a + b + c + d;
>>> }
>>> -int noinline bpf_fentry_test5(u64 a, void *b, short c, int d, u64 e)
>>> +static noinline int bpf_fentry_test5(u64 a, void *b, short c, int d,
>>> u64 e)
>>> {
>>> return a + (long)b + c + d + e;
>>> }
>>> -int noinline bpf_fentry_test6(u64 a, void *b, short c, int d, void
>>> *e, u64 f)
>>> +static noinline int bpf_fentry_test6(u64 a, void *b, short c, int d,
>>> void *e, u64 f)
>>> {
>>> return a + (long)b + c + d + (long)e + f;
>>> }
>>>
>
next prev parent reply other threads:[~2020-03-23 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 14:08 [PATCH] bpf: fix build warning - missing prototype Jean-Philippe Menil
2020-03-23 5:32 ` Yonghong Song
2020-03-23 7:42 ` Jean-Philippe Menil
2020-03-23 14:52 ` Yonghong Song [this message]
2020-03-24 7:22 ` [PATCH v2] " Jean-Philippe Menil
2020-03-24 16:19 ` Yonghong Song
2020-03-26 23:54 ` Alexei Starovoitov
2020-03-27 7:55 ` [PATCH v3] " Jean-Philippe Menil
2020-03-27 20:34 ` Daniel Borkmann
2020-03-27 20:47 ` [PATCH v4] " Jean-Philippe Menil
2020-03-28 17:15 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c27e51f-6a64-7374-b705-450cad42146c@fb.com \
--to=yhs@fb.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jpmenil@gmail.com \
--cc=kafai@fb.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).