From: Daniel Borkmann <daniel@iogearbox.net>
To: "Yonghong Song" <yhs@fb.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next] libbpf: Fix libbpf_common.h when installing libbpf through 'make install'
Date: Wed, 18 Dec 2019 00:21:43 +0100 [thread overview]
Message-ID: <7e88179c-155e-ce8c-4641-debad4ca0631@iogearbox.net> (raw)
In-Reply-To: <c6a49edd-3992-6ddc-58d9-2c37acdeeece@fb.com>
On 12/17/19 10:58 PM, Yonghong Song wrote:
> On 12/17/19 3:28 AM, Toke Høiland-Jørgensen wrote:
>> This fixes two issues with the newly introduced libbpf_common.h file:
>>
>> - The header failed to include <string.h> for the definition of memset()
>> - The new file was not included in the install_headers rule in the Makefile
>>
>> Both of these issues cause breakage when installing libbpf with 'make
>> install' and trying to use it in applications.
>>
>> Fixes: 544402d4b493 ("libbpf: Extract common user-facing helpers")
>> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
> Acked-by: Yonghong Song <yhs@fb.com>
Applied, thanks!
prev parent reply other threads:[~2019-12-17 23:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 11:28 [PATCH bpf-next] libbpf: Fix libbpf_common.h when installing libbpf through 'make install' Toke Høiland-Jørgensen
2019-12-17 21:58 ` Yonghong Song
2019-12-17 23:21 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e88179c-155e-ce8c-4641-debad4ca0631@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).