From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>, bpf@vger.kernel.org
Subject: Re: [PATCH bpf v2] samples: bpf: Fix vmlinux.h generation for XDP samples
Date: Tue, 28 Sep 2021 15:44:49 +0200 [thread overview]
Message-ID: <874ka4ke5q.fsf@toke.dk> (raw)
In-Reply-To: <20210928054608.1799021-1-memxor@gmail.com>
Kumar Kartikeya Dwivedi <memxor@gmail.com> writes:
> Generate vmlinux.h only from the in-tree vmlinux, and remove enum
> declarations that would cause a build failure in case of version
> mismatches.
>
> There are now two options when building the samples:
> 1. Compile the kernel to use in-tree vmlinux for vmlinux.h
> 2. Override VMLINUX_BTF for samples using something like this:
> make VMLINUX_BTF=/sys/kernel/btf/vmlinux -C samples/bpf
>
> This change was tested with relative builds, e.g. cases like:
> * make O=build -C samples/bpf
> * make KBUILD_OUTPUT=build -C samples/bpf
> * make -C samples/bpf
> * cd samples/bpf && make
>
> When a suitable VMLINUX_BTF is not found, the following message is
> printed:
> /home/kkd/src/linux/samples/bpf/Makefile:333: *** Cannot find a vmlinux
> for VMLINUX_BTF at any of " ./vmlinux", build the kernel or set
> VMLINUX_BTF variable. Stop.
>
> Cc: Toke Høiland-Jørgensen <toke@redhat.com>
> Fixes: 384b6b3bbf0d (samples: bpf: Add vmlinux.h generation support)
> Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2021-09-28 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 5:46 [PATCH bpf v2] samples: bpf: Fix vmlinux.h generation for XDP samples Kumar Kartikeya Dwivedi
2021-09-28 13:44 ` Toke Høiland-Jørgensen [this message]
2021-09-29 0:35 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ka4ke5q.fsf@toke.dk \
--to=toke@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=memxor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).