From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Eelco Chaudron <echaudro@redhat.com>, bpf@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org, ast@kernel.org,
daniel@iogearbox.net, kafai@fb.com, songliubraving@fb.com,
yhs@fb.com, andriin@fb.com
Subject: Re: [PATCH bpf-next] libbpf: Add support for dynamic program attach target
Date: Wed, 12 Feb 2020 14:05:13 +0100 [thread overview]
Message-ID: <874kvwhs6u.fsf@toke.dk> (raw)
In-Reply-To: <158151067149.71757.2222114135650741733.stgit@xdp-tutorial>
Eelco Chaudron <echaudro@redhat.com> writes:
> Currently when you want to attach a trace program to a bpf program
> the section name needs to match the tracepoint/function semantics.
>
> However the addition of the bpf_program__set_attach_target() API
> allows you to specify the tracepoint/function dynamically.
>
> The call flow would look something like this:
>
> xdp_fd = bpf_prog_get_fd_by_id(id);
> trace_obj = bpf_object__open_file("func.o", NULL);
> prog = bpf_object__find_program_by_title(trace_obj,
> "fentry/myfunc");
> bpf_program__set_attach_target(prog, xdp_fd,
> "fentry/xdpfilt_blk_all");
I think it would be better to have the attach type as a separate arg
instead of encoding it in the function name. I.e., rather:
bpf_program__set_attach_target(prog, xdp_fd,
"xdpfilt_blk_all", BPF_TRACE_FENTRY);
-Toke
next prev parent reply other threads:[~2020-02-12 13:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 12:31 [PATCH bpf-next] libbpf: Add support for dynamic program attach target Eelco Chaudron
2020-02-12 13:05 ` Toke Høiland-Jørgensen [this message]
2020-02-12 17:35 ` Andrii Nakryiko
2020-02-12 21:52 ` Toke Høiland-Jørgensen
2020-02-13 14:41 ` Eelco Chaudron
2020-02-12 17:34 ` Andrii Nakryiko
2020-02-12 17:56 ` Song Liu
2020-02-12 18:14 ` Andrii Nakryiko
2020-02-12 18:28 ` Song Liu
2020-02-12 18:34 ` Andrii Nakryiko
2020-02-12 18:40 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kvwhs6u.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=echaudro@redhat.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).