From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F12B0C3F2D1 for ; Thu, 5 Mar 2020 12:54:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BBF8D208C3 for ; Thu, 5 Mar 2020 12:54:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="f6PmxY+O" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726094AbgCEMyD (ORCPT ); Thu, 5 Mar 2020 07:54:03 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:53043 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725991AbgCEMyD (ORCPT ); Thu, 5 Mar 2020 07:54:03 -0500 Received: by mail-wm1-f67.google.com with SMTP id p9so6189246wmc.2 for ; Thu, 05 Mar 2020 04:54:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=UithumxeWzYgScx9rLpMyD2GJqEdo81auVSNbfn9oiY=; b=f6PmxY+OolwFWG6Qlwyz2Vw3Fx3A+kmQsoP2kyPGcXtEWvliRhBV5iONwsB4PRtoHu HvtCtJiLV+XvTInlE90TtwWIowBizogvXcRXTobxU9eLqYTvBiNAsfyp4qIXeCRp7xR0 LGoYy8e9/mmZW1JFe/3FVRueKfq8NbiHwb5Qg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=UithumxeWzYgScx9rLpMyD2GJqEdo81auVSNbfn9oiY=; b=B3jW6ObalKDPsi2uJ1unvsbn5ac5IYHzI9Z5pInGQnZlW/G1Hu+PKGZxOoXGjF6Z+n idEkvLsYjY87FN+NESCRdFnOcsluB2a6TaAPFjJE1XW23yq+24kHm8+kbdiAl5o6X6Pg loBaJn0LUR3kdl5YfatH/1qyekTKwQ8HNF4Qy3e2IHEvZ/KJsdHcGcMQ0w7LnSBpbRWN Ymu9D6DxoUyTO3sRpYejawqAxjZYgru+Uw46JJSScGwgMecY+sYvxBOk3vK9bWYLDjsI 43lb89QDxczihI2vbNsa/a4n7gqA0pRfjT9LwY6acKCyiWGR648UDLlt9HCdrRUALtfA Tr6w== X-Gm-Message-State: ANhLgQ3Wl5b1nSp55rvXj49IPDSfuUPLqWfgkwOrOkjb2pNIdSDvKdM6 LYPZqNhBP1JiO1wP+ClmAHii8A== X-Google-Smtp-Source: ADFU+vtVxwix/QuB6JjhX0awb1vybd4BvpFB+lIY68z69hOr/TCDPZBDyFJM31X5dKcZBJjdP0iwtw== X-Received: by 2002:a1c:7c08:: with SMTP id x8mr9227427wmc.71.1583412841132; Thu, 05 Mar 2020 04:54:01 -0800 (PST) Received: from cloudflare.com ([176.221.114.230]) by smtp.gmail.com with ESMTPSA id i18sm41145017wrv.30.2020.03.05.04.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2020 04:54:00 -0800 (PST) References: <20200304101318.5225-1-lmb@cloudflare.com> <20200304101318.5225-10-lmb@cloudflare.com> User-agent: mu4e 1.1.0; emacs 26.3 From: Jakub Sitnicki To: Lorenz Bauer Cc: john.fastabend@gmail.com, Shuah Khan , Alexei Starovoitov , Daniel Borkmann , kernel-team@cloudflare.com, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v3 09/12] selftests: bpf: don't listen() on UDP sockets In-reply-to: <20200304101318.5225-10-lmb@cloudflare.com> Date: Thu, 05 Mar 2020 13:53:59 +0100 Message-ID: <878skfynbs.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Mar 04, 2020 at 11:13 AM CET, Lorenz Bauer wrote: > Most tests for TCP sockmap can be adapted to UDP sockmap if the > listen call is skipped. Rename listen_loopback, etc. to socket_loopback > and skip listen() for SOCK_DGRAM. > > Signed-off-by: Lorenz Bauer > --- FWIW, Go has net.ListenUDP so I don't think it would be very confusing to leave the helper name as is. Reviewed-by: Jakub Sitnicki [...]