From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C34B7C3F2D1 for ; Thu, 5 Mar 2020 12:32:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CA822072A for ; Thu, 5 Mar 2020 12:32:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="T3wLGGd4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726090AbgCEMcJ (ORCPT ); Thu, 5 Mar 2020 07:32:09 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:32872 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725977AbgCEMcI (ORCPT ); Thu, 5 Mar 2020 07:32:08 -0500 Received: by mail-wm1-f65.google.com with SMTP id a25so6988558wmm.0 for ; Thu, 05 Mar 2020 04:32:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=XvqoB3YpTGvwS70Yx+o81kC3OP5qwjPAewaCKlcb6hw=; b=T3wLGGd4TFmeHvgA1nuM53qFrkJDFyrA1MdY080q3OYGZwSp7Epdjm3D5fCR+9sPzD HhKNAmSmWIPWUNohY4rbT/AA4u0fbwHRWxKxdmyiyrqUG5YrupzM39MM6xn/YBtRLH5M ZwdLlQoMOkVNKw5IAWUk9hRmklUu9PR2XatJg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=XvqoB3YpTGvwS70Yx+o81kC3OP5qwjPAewaCKlcb6hw=; b=NW4Ad0BRq0wnNAYylnCdXYlG0EQ94ET1rVNMo2q3JEZQqrBzBCAX5x4OODaOBWeJZK +TXlCFPJYGkiYY0xRijZgkj/HLJYGjsTmalX+OwrtQlaxHulb8YYuG0Hb8c6D7z4aEC/ wCY22Cv1pIu8cxeMw4e5z+nPKgUPZPZx6kbVaWybZrW31mfTaAohr/suR+WiD9PF+KYf E3Zx2/Pu1jkhI9kXf+9O88DWX0lZGxbSYbuKwTHdZJVjINUxBQ96YkXazjrkVvQjdN6W BKmiIYC9m/Ygu48KzGiWkArsPgUbhckqRtvgIRQjrz0/DnUxaWrdTTPX5Z+J2hml6JGX X5+g== X-Gm-Message-State: ANhLgQ0TrXRUebHkpSTlVoJrdv7CcT0nkJKUq/VJZ0u9mfey5Vt9ybv8 4noMrhK6NindLetkfpDDCcug0A== X-Google-Smtp-Source: ADFU+vs0s6JDpJz9Ahed3MeuIOLTRos26RvIX28l24f5TQaaBz1cvByfsJgGNQ/pkbU0F2hDoISdNg== X-Received: by 2002:a1c:8041:: with SMTP id b62mr9174507wmd.76.1583411525674; Thu, 05 Mar 2020 04:32:05 -0800 (PST) Received: from cloudflare.com ([176.221.114.230]) by smtp.gmail.com with ESMTPSA id b186sm9273626wmb.40.2020.03.05.04.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2020 04:32:05 -0800 (PST) References: <20200304101318.5225-1-lmb@cloudflare.com> <20200304101318.5225-6-lmb@cloudflare.com> User-agent: mu4e 1.1.0; emacs 26.3 From: Jakub Sitnicki To: Lorenz Bauer Cc: john.fastabend@gmail.com, Alexei Starovoitov , Daniel Borkmann , Eric Dumazet , "David S. Miller" , Jakub Kicinski , Alexey Kuznetsov , Hideaki YOSHIFUJI , kernel-team@cloudflare.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v3 05/12] bpf: sockmap: move generic sockmap hooks from BPF TCP In-reply-to: <20200304101318.5225-6-lmb@cloudflare.com> Date: Thu, 05 Mar 2020 13:32:04 +0100 Message-ID: <87blpbyocb.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Mar 04, 2020 at 11:13 AM CET, Lorenz Bauer wrote: > The init, close and unhash handlers from TCP sockmap are generic, > and can be reused by UDP sockmap. Move the helpers into the sockmap code > base and expose them. This requires tcp_bpf_get_proto and tcp_bpf_clone to > be conditional on BPF_STREAM_PARSER. > > The moved functions are unmodified, except that sk_psock_unlink is > renamed to sock_map_unlink to better match its behaviour. > > Signed-off-by: Lorenz Bauer > --- To spell out the tcp_bpf_get_proto() and tcp_bpf_clone() dependency on CONFIG_BPF_STREAM_PARSER - both of these functions access tcp_bpf_prots, which now hold pointers to sock_map_{unhash,close}. And sock_map_{unhash,close} get built when CONFIG_BPF_STREAM_PARSER is enabled. Reviewed-by: Jakub Sitnicki [...]