From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF1E4C43331 for ; Mon, 11 Nov 2019 09:24:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F8F12075C for ; Mon, 11 Nov 2019 09:24:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JL7eEtTE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726879AbfKKJY5 (ORCPT ); Mon, 11 Nov 2019 04:24:57 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:39169 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726853AbfKKJY5 (ORCPT ); Mon, 11 Nov 2019 04:24:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573464296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Nj1jXUErntBq71VW4mO6DE48JXy/eVyWGhHD6EUL/w=; b=JL7eEtTEiH0JO2ROBnq+E8u6EwcOobu8L0kafeeq4GXaT7Wxpm/Ubgi0hq1vn3Zlsy38HD i3rcGr7ScopVWhgWjhsN9w/6VbpYTTgvxwvX2uJcY6vypivmn5Vj0naq5A29lqJ1pYjwKs ZM7gfI/huxO3gHD6sHBbfngJ47WwHF8= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-ni6FWAnPPBSpTIwSzSQY3A-1; Mon, 11 Nov 2019 04:24:53 -0500 Received: by mail-ed1-f70.google.com with SMTP id c16so9763886edt.17 for ; Mon, 11 Nov 2019 01:24:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=rK/IE93Ia0gre+In92ABappDCl0/7Lq4UUq1d9yP+l8=; b=NL7QEtDenSlcmc8qUQ7GZMcVsmiAuaRkMOO/SsiMf9cj+G0QO3ADfuVB6OqYQMieHd 9cRppsFbh+5kQlLfvsGBnfFhISYCisjj/6mxmSjRZQf8YlpfXgjXj7If4YEH19FNVceS QStrs7WTLzor3APgTGsX/FIGzTTFM+kqkAUvM6dpD9Btm+daeaQoVLr45fVTu8x+6uOG wIQjrepK5KiA1GhTVQzfA/ZEs5k10OPvCL42tT5+f9GM2AGPlwLxC4aocRMSlfAJ53MN HTzhNINanb/F7o8FmrwJqLUaLzJXPxj7Te8Ir6U+aiMj2wo2yOuIzHyWgE1lnlAyxGkG 9Qjg== X-Gm-Message-State: APjAAAVjEzvQyXgg9kA2hTT3q9FhjqI6KiteLKVAtPXYohif5RN+dwV8 VxIhfQv5/MCUjo8SB1m7AoIYi3cVX5+d3xF2Db6BVHthoLMGf8yiDuaZjSDA79iIR5dut3kYf+E 0poqnMX3UvEWs X-Received: by 2002:a17:907:205b:: with SMTP id pg27mr20914430ejb.144.1573464292322; Mon, 11 Nov 2019 01:24:52 -0800 (PST) X-Google-Smtp-Source: APXvYqyY6vIm3jnwFOPQ5+TYCcaRZda+A8DqvSf5r53dbg58NtJln5wV1fGdG9IluCcVLn8vPcWIUw== X-Received: by 2002:a17:907:205b:: with SMTP id pg27mr20914421ejb.144.1573464292138; Mon, 11 Nov 2019 01:24:52 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id h3sm145062ejp.11.2019.11.11.01.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 01:24:51 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id E1A761803C7; Mon, 11 Nov 2019 10:24:50 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Andrii Nakryiko , "Daniel T. Lee" Cc: Daniel Borkmann , Alexei Starovoitov , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Andrii Nakryiko , Networking , bpf Subject: Re: [PATCH] samples: bpf: fix outdated README build command In-Reply-To: References: <20191110081901.20851-1-danieltimlee@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 11 Nov 2019 10:24:50 +0100 Message-ID: <87bltircil.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: ni6FWAnPPBSpTIwSzSQY3A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Andrii Nakryiko writes: > On Sun, Nov 10, 2019 at 12:19 AM Daniel T. Lee w= rote: >> >> Currently, building the bpf samples under samples/bpf directory isn't >> working. Running make from the directory 'samples/bpf' will just shows >> following result without compiling any samples. >> > > Do you mind trying to see if it's possible to detect that plain `make` > is being run from samples/bpf subdirectory, and if that's the case, > just running something like `make M=3Dsamples/bpf -C ../../`? If that's > not too hard, it would be a nice touch to still have it working old > (and intuitive) way, IMO. I think it's just the M=3D that's missing. Tentatively, the below seems to work for me (I get some other compile errors, but I think that is unrelated). -Toke diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile index 8a9af3ab7769..48e7f1ff7861 100644 --- a/samples/bpf/Makefile +++ b/samples/bpf/Makefile @@ -246,7 +246,7 @@ endif =20 # Trick to allow make to be run from this directory all: - $(MAKE) -C ../../ $(CURDIR)/ BPF_SAMPLES_PATH=3D$(CURDIR) + $(MAKE) -C ../../ M=3D$(CURDIR) BPF_SAMPLES_PATH=3D$(CURDIR) =20 clean: $(MAKE) -C ../../ M=3D$(CURDIR) clean