From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 706ABC2D0DB for ; Mon, 27 Jan 2020 13:03:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 432EF214D8 for ; Mon, 27 Jan 2020 13:03:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="GAPCdOUU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725938AbgA0ND0 (ORCPT ); Mon, 27 Jan 2020 08:03:26 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:35003 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbgA0NDZ (ORCPT ); Mon, 27 Jan 2020 08:03:25 -0500 Received: by mail-lf1-f67.google.com with SMTP id z18so6132575lfe.2 for ; Mon, 27 Jan 2020 05:03:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=VDyYhqW8q5Ak22YpLURiDz1wi+K6rv4J/LUbazxWPYs=; b=GAPCdOUUYv3Mo0M2HYvF7mHmqT1+90QUtscvLVOKuba0f9wPDvpHDgs9W0/X74xop+ 726ry5P6zg3sBMb2oJOP4lz7aGgsdQWzg6x5U4CWnhvJLqQJ0qBeCBbCx3lQvUzyioAd a8CNjukCsZSP3V7wy8LsQ1KVlsCB6TokRmowQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=VDyYhqW8q5Ak22YpLURiDz1wi+K6rv4J/LUbazxWPYs=; b=Frd44o+lTshWpPAPLXlAJyKPfxlOonBOw9slZ6Fm/cFdZlRsnanxxYNC3bGewBgiXl JAWw/I5yl4Z5LaXJGA93v/6Qo+MtnSzoW3w9hliesR8ZXuTr1TS6EgjXjlXtPmBL4rvz 8hyarb4ynnnZa/1pfSvVXSRj++Q971Ssams3HPE7IdYGeq2z+tUZIKYQOKUlTDcIIHfu /4GWFLSURzuJvp7gTXCoHQRppwDaVmhjFu8/nWONUveJJ2VrLKGrMIiaocagrk49H1jd cFIKmycU/5TrFWxQee45vNcUzwd8b/rX1BT2zcRAEsobGQ3w3I6Mu1WkSWPW0FffEB0m kmhA== X-Gm-Message-State: APjAAAW6fAbMqf9ue7ik0tQf6V2cEldlS0uvjZVkw3Z7X+LFAndkmhs4 siqXg13RvaEwB5eSrjfuyucbPw== X-Google-Smtp-Source: APXvYqzW5lUoX8CpDni33LG4u5BwSsBKkY+fAIGhsC7Gvqb7txl28YVOZ26kyOJlPoYh7OJVoXtr1Q== X-Received: by 2002:a19:48c5:: with SMTP id v188mr8199626lfa.100.1580130203982; Mon, 27 Jan 2020 05:03:23 -0800 (PST) Received: from cloudflare.com ([2a02:a310:c262:aa00:b35e:8938:2c2a:ba8b]) by smtp.gmail.com with ESMTPSA id n30sm10097363lfi.54.2020.01.27.05.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jan 2020 05:03:23 -0800 (PST) References: <20200123155534.114313-1-jakub@cloudflare.com> User-agent: mu4e 1.1.0; emacs 26.3 From: Jakub Sitnicki To: Daniel Borkmann Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, kernel-team@cloudflare.com, John Fastabend , Lorenz Bauer , Martin Lau Subject: Re: [PATCH bpf-next v4 00/12] Extend SOCKMAP to store listening sockets In-reply-to: Date: Mon, 27 Jan 2020 14:03:22 +0100 Message-ID: <87d0b5caqt.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Jan 27, 2020 at 12:13 PM CET, Daniel Borkmann wrote: > On 1/23/20 4:55 PM, Jakub Sitnicki wrote: > [...] >> Jakub Sitnicki (12): >> bpf, sk_msg: Don't clear saved sock proto on restore >> net, sk_msg: Annotate lockless access to sk_prot on clone >> net, sk_msg: Clear sk_user_data pointer on clone if tagged >> tcp_bpf: Don't let child socket inherit parent protocol ops on copy >> bpf, sockmap: Allow inserting listening TCP sockets into sockmap >> bpf, sockmap: Don't set up sockmap progs for listening sockets >> bpf, sockmap: Return socket cookie on lookup from syscall >> bpf, sockmap: Let all kernel-land lookup values in SOCKMAP >> bpf: Allow selecting reuseport socket from a SOCKMAP >> net: Generate reuseport group ID on group creation >> selftests/bpf: Extend SK_REUSEPORT tests to cover SOCKMAP >> selftests/bpf: Tests for SOCKMAP holding listening sockets >> >> include/linux/skmsg.h | 15 +- >> include/net/sock.h | 37 +- >> include/net/sock_reuseport.h | 2 - >> include/net/tcp.h | 7 + >> kernel/bpf/reuseport_array.c | 5 - >> kernel/bpf/verifier.c | 6 +- >> net/core/filter.c | 27 +- >> net/core/skmsg.c | 2 +- >> net/core/sock.c | 11 +- >> net/core/sock_map.c | 133 +- >> net/core/sock_reuseport.c | 50 +- >> net/ipv4/tcp_bpf.c | 17 +- >> net/ipv4/tcp_minisocks.c | 2 + >> net/ipv4/tcp_ulp.c | 3 +- >> net/tls/tls_main.c | 3 +- >> .../bpf/prog_tests/select_reuseport.c | 60 +- >> .../selftests/bpf/prog_tests/sockmap_listen.c | 1455 +++++++++++++++++ >> .../selftests/bpf/progs/test_sockmap_listen.c | 77 + >> tools/testing/selftests/bpf/test_maps.c | 6 +- >> 19 files changed, 1811 insertions(+), 107 deletions(-) >> create mode 100644 tools/testing/selftests/bpf/prog_tests/sockmap_listen.c >> create mode 100644 tools/testing/selftests/bpf/progs/test_sockmap_listen.c >> > > Unfortunately, the series needs one last rebase in order to be applied due > to conflicts from John's earlier sockmap/tls fixes from Jan/11th [0]. If it's not too late, it has been now rebased [0]. Thanks, -jkbs [0] https://lore.kernel.org/bpf/87eevlcauo.fsf@cloudflare.com/T/#t