From: Joe Perches <joe@perches.com>
To: Song Liu <songliubraving@fb.com>, linux-kernel@vger.kernel.org
Cc: bpf@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] checkpatch: do not apply "initialise globals to 0" check to BPF progs
Date: Mon, 08 Feb 2021 22:29:50 -0800 [thread overview]
Message-ID: <87ec5ac2e1a41000da9a7158491a22f83295c1a6.camel@perches.com> (raw)
In-Reply-To: <20210208234002.3294265-1-songliubraving@fb.com>
On Mon, 2021-02-08 at 15:40 -0800, Song Liu wrote:
> BPF programs explicitly initialise global variables to 0 to make sure
> clang (v10 or older) do not put the variables in the common section.
> Skip "initialise globals to 0" check for BPF programs to elimiate error
> messages like:
>
> ERROR: do not initialise globals to 0
> #19: FILE: samples/bpf/tracex1_kern.c:21:
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4323,7 +4323,11 @@ sub process {
> }
>
>
> # check for global initialisers.
> - if ($line =~ /^\+$Type\s*$Ident(?:\s+$Modifier)*\s*=\s*($zero_initializer)\s*;/) {
> +# Do not apply to BPF programs (tools/testing/selftests/bpf/progs/*.c, samples/bpf/*_kern.c, *.bpf.c).
> + if ($line =~ /^\+$Type\s*$Ident(?:\s+$Modifier)*\s*=\s*($zero_initializer)\s*;/ &&
> + $realfile !~ /^tools\/testing\/selftests\/bpf\/progs\/.*\.c/ &&
> + $realfile !~ /^samples\/bpf\/.*_kern.c/ &&
> + $realfile !~ /.bpf.c$/) {
probably better to make this a function so when additional files are
added it'd be easier to update this and it will not look as complex.
if ($line =~ /.../ &&
!exclude_global_initialisers($realfile))
> if (ERROR("GLOBAL_INITIALISERS",
> "do not initialise globals to $1\n" . $herecurr) &&
> $fix) {
next prev parent reply other threads:[~2021-02-09 6:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 23:40 [PATCH] checkpatch: do not apply "initialise globals to 0" check to BPF progs Song Liu
2021-02-09 6:29 ` Joe Perches [this message]
2021-02-09 16:47 ` Song Liu
2021-02-09 6:31 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ec5ac2e1a41000da9a7158491a22f83295c1a6.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).