From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D66DC432C0 for ; Tue, 26 Nov 2019 14:32:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 732B020722 for ; Tue, 26 Nov 2019 14:32:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="cvFDEBMX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727664AbfKZOcg (ORCPT ); Tue, 26 Nov 2019 09:32:36 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:34824 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727418AbfKZOcg (ORCPT ); Tue, 26 Nov 2019 09:32:36 -0500 Received: by mail-lf1-f68.google.com with SMTP id r15so11349397lff.2 for ; Tue, 26 Nov 2019 06:32:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=pQvSJ/V/b6U4GcI3ILMxAFDCLr21ECkN15nERg7+uEA=; b=cvFDEBMXHl0scmQJdI578WTIitkXsKUgx6c/hCLXsYJVjhh8HBIQs0XujvKaobSCRb 4sd1gwDYtv+PURSPlNR5UuE7WnnhYJOcfF64i6BcDR7Hu6G+GU4hejHpAk+SUMo3pa2x keMNVpkyYlPiBT4zCHLjQxPN76zGTDKTcme40= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=pQvSJ/V/b6U4GcI3ILMxAFDCLr21ECkN15nERg7+uEA=; b=JWSA01l1DzJ9M16yRNIzjSHzXYyO6Mpnfl5QVt4aETeoeJ4/aDAaFamBkmlK+t1VZQ BulkQ+Xliw2J+xCaMpnMxfukxU0DHQzomTztKAUzE7N4kWfodIq3hXPTXQFFBVASc1mL 1IW7BvKcl08gZmpTNrgOy2u1voB49uZWGLwEDpjhiUVT4MSn6VQSZy6euJeMpdtlXAUl 1mQNbqls7ncaBiFRvbxZJIgocCHKId0wZ/Qsyxp067PkroVA/JCdqJVVb/9IGpXEnIQt ybjbnvvqGbJlop60hTpiORTHOnC9sCtpEyy+5XNUhhoP1tC+/FsXKS6M398C9nKzSv/h +Ajg== X-Gm-Message-State: APjAAAUoFaKgAtUxN8gu1DT14OcmFEr8+lUZOB6P0miPg87jnRKqoE9f PYz0G4ENmbPwViEYuZ7tzX2OiQ== X-Google-Smtp-Source: APXvYqwN5qBJzkc1AmqDYNHCOO3HvUwedfZbKqblKDTGusTRzi3U5P6FEi0KwnLQxAXfzuTwAFbhIA== X-Received: by 2002:ac2:4436:: with SMTP id w22mr13554205lfl.185.1574778753467; Tue, 26 Nov 2019 06:32:33 -0800 (PST) Received: from cloudflare.com ([176.221.114.230]) by smtp.gmail.com with ESMTPSA id e27sm5394444lfb.79.2019.11.26.06.32.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 06:32:32 -0800 (PST) References: <20191123110751.6729-1-jakub@cloudflare.com> <20191123110751.6729-8-jakub@cloudflare.com> <20191125222958.aaplyw7ebtqs6yyl@kafai-mbp> User-agent: mu4e 1.1.0; emacs 26.1 From: Jakub Sitnicki To: Martin Lau Cc: "bpf\@vger.kernel.org" , "netdev\@vger.kernel.org" , "kernel-team\@cloudflare.com" , John Fastabend Subject: Re: [PATCH bpf-next 7/8] selftests/bpf: Extend SK_REUSEPORT tests to cover SOCKMAP In-reply-to: <20191125222958.aaplyw7ebtqs6yyl@kafai-mbp> Date: Tue, 26 Nov 2019 15:32:32 +0100 Message-ID: <87h82qoghr.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Nov 25, 2019 at 11:30 PM CET, Martin Lau wrote: > On Sat, Nov 23, 2019 at 12:07:50PM +0100, Jakub Sitnicki wrote: >> Parametrize the SK_REUSEPORT tests so that the map type for storing sockets >> can be selected at run-time. Also allow choosing which L4 protocols get >> tested. > If new cmdline args are added to select different subtests, > I would prefer to move it to the test_progs framework and reuse the subtests > support in test_progs commit 3a516a0a3a7b ("selftests/bpf: add sub-tests support for test_progs"). > Its default is to run all instead of having a separate bash script to > do that. Great idea. Let me convert these tests and the newly added ones to test_progs framework. -Jakub