From: Jakub Sitnicki <jakub@cloudflare.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
kernel-team@cloudflare.com, Stanislav Fomichev <sdf@fomichev.me>
Subject: Re: [PATCH bpf-next v2 0/2] Atomic flow dissector updates
Date: Fri, 11 Oct 2019 10:31:17 +0200 [thread overview]
Message-ID: <87imov1y5m.fsf@cloudflare.com> (raw)
In-Reply-To: <20191010233840.GA20202@pc-63.home>
On Fri, Oct 11, 2019 at 01:38 AM CEST, Daniel Borkmann wrote:
> On Thu, Oct 10, 2019 at 08:17:48PM +0200, Jakub Sitnicki wrote:
>> This patch set changes how bpf(BPF_PROG_ATTACH) operates on flow dissector
>> hook when there is already a program attached. After this change the user
>> is allowed to update the program in a single syscall. Please see the first
>> patch for rationale.
>>
>> v1 -> v2:
>>
>> - Don't use CHECK macro which expects BPF program run duration, which we
>> don't track in attach/detach tests. Suggested by Stanislav Fomichev.
>>
>> - Test re-attaching flow dissector in both root and non-root network
>> namespace. Suggested by Stanislav Fomichev.
>>
>>
>> Jakub Sitnicki (2):
>> flow_dissector: Allow updating the flow dissector program atomically
>> selftests/bpf: Check that flow dissector can be re-attached
>>
>> net/core/flow_dissector.c | 10 +-
>> .../bpf/prog_tests/flow_dissector_reattach.c | 127 ++++++++++++++++++
>> 2 files changed, 134 insertions(+), 3 deletions(-)
>> create mode 100644 tools/testing/selftests/bpf/prog_tests/flow_dissector_reattach.c
>
> This needs a new rebase, doesn't apply cleanly. Please carry on Martin
> and Stanislav's tags. Thanks!
Rebased and posted v3. Thanks to Martin and Stanislav for reviewing it.
-Jakub
prev parent reply other threads:[~2019-10-11 8:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 18:17 [PATCH bpf-next v2 0/2] Atomic flow dissector updates Jakub Sitnicki
2019-10-10 18:17 ` [PATCH bpf-next v2 1/2] flow_dissector: Allow updating the flow dissector program atomically Jakub Sitnicki
2019-10-10 19:41 ` Martin Lau
2019-10-10 18:17 ` [PATCH bpf-next v2 2/2] selftests/bpf: Check that flow dissector can be re-attached Jakub Sitnicki
2019-10-10 19:42 ` Martin Lau
2019-10-10 19:57 ` [PATCH bpf-next v2 0/2] Atomic flow dissector updates Stanislav Fomichev
2019-10-10 23:38 ` Daniel Borkmann
2019-10-11 8:31 ` Jakub Sitnicki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imov1y5m.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).