From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 769B9C10F14 for ; Thu, 3 Oct 2019 07:35:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4AD4021D71 for ; Thu, 3 Oct 2019 07:35:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dfURVNUP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725613AbfJCHfh (ORCPT ); Thu, 3 Oct 2019 03:35:37 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:42080 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728180AbfJCHfh (ORCPT ); Thu, 3 Oct 2019 03:35:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570088136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hVX9o2aIsobjvj9ovzq4arMUSieRziwrjgJlpz007LQ=; b=dfURVNUPSJKhy7rAZbyieYRbYKVBSzYwtXPG1o6r+sO0F57ls+so7AzgFiRVDvgwojb9SD Y5Uu6Wp6ocWPHm2yxO0VXvxgiJt0p9ltZOcj8i8ek2fW4oU6hcaQPx4NdSlzf7+P2XEKIh KOSs3cS+tMhWmrAhxKX66Iq47Hp3wvM= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-gBKfVEKSNxGaLFWNBsOrZA-1; Thu, 03 Oct 2019 03:35:34 -0400 Received: by mail-lj1-f199.google.com with SMTP id r22so550627ljg.15 for ; Thu, 03 Oct 2019 00:35:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=9yhr1Y6R6hpoctBnwHfdToZ6WWRJL/XNPXCJTovhDIU=; b=hF8i3MXWVgHaA+G5OSKU2SsrvarOoS92ziuiQ0F8PsYDpqVg0AmA+qb6uYE62JM1ly qATkpziE1A22CS/Vco0c9kCNKaGA+dRpyuMGPse+GVST5GnIBJLJDgsiaBzOQt+vNEew 1HqbeKd6SkGPA3DSp7bUNBZ3lpT7nZx0Z/fNh34PNpTuB2ls+dH3dGFEkRdHBE9bpP0S iwWrfIYK9lp7iaQB7sExFR1WWpKqUPw3uekhapRd9LgFgsQgSqHPBbuptTMU2inMtYqw XIPOE3mKQKV2dpCSOHgXid8qS9ad3GE61VllChHLyyn8FyKk41R4iN2CP7DHun0FPggj siTw== X-Gm-Message-State: APjAAAWN5beKsoTRNEdOinoUHDVWsg3bto8+bs7xCpU2V0ipvfIldyv8 h0UeiOKTdSDiSfaiLObg3psxMqtAqGhmDVwoIsjNUatGtXi+JOLznTYtXMFmruJVYrsfpXiYEcn vr2GNEbdAG2Sn X-Received: by 2002:a2e:3e09:: with SMTP id l9mr2692194lja.215.1570088133427; Thu, 03 Oct 2019 00:35:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqzChFE89gT7cYlzbxzsN4dmLGPxh6F7LE7US0V9HALZ/1N+fiPxQ42CkJYNDvYfQXUMeylcrg== X-Received: by 2002:a2e:3e09:: with SMTP id l9mr2692188lja.215.1570088133289; Thu, 03 Oct 2019 00:35:33 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id i11sm350007ljb.74.2019.10.03.00.35.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2019 00:35:32 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id F39B918063D; Thu, 3 Oct 2019 09:35:31 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Andrii Nakryiko , bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com, daniel@iogearbox.net Cc: andrii.nakryiko@gmail.com, kernel-team@fb.com, Andrii Nakryiko Subject: Re: [PATCH v2 bpf-next 4/7] selftests/bpf: split off tracing-only helpers into bpf_tracing.h In-Reply-To: <20191002215041.1083058-5-andriin@fb.com> References: <20191002215041.1083058-1-andriin@fb.com> <20191002215041.1083058-5-andriin@fb.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 03 Oct 2019 09:35:31 +0200 Message-ID: <87imp6qo1o.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: gBKfVEKSNxGaLFWNBsOrZA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Andrii Nakryiko writes: > +/* a helper structure used by eBPF C program > + * to describe BPF map attributes to libbpf loader > + */ > +struct bpf_map_def { > +=09unsigned int type; > +=09unsigned int key_size; > +=09unsigned int value_size; > +=09unsigned int max_entries; > +=09unsigned int map_flags; > +}; Why is this still here? There's already an identical definition in libbpf.h= ... -Toke