From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DB89C07E99 for ; Mon, 5 Jul 2021 17:06:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29E0661977 for ; Mon, 5 Jul 2021 17:06:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229785AbhGERJI (ORCPT ); Mon, 5 Jul 2021 13:09:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29608 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229743AbhGERJI (ORCPT ); Mon, 5 Jul 2021 13:09:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625504790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KuRy89eXRByFxlnTN23uE6bhIohFVEQlDPFd8c6xtSg=; b=NIK/2adLFFIyPAa2rthe+Uhpc6pI1el/FZ3yV8vMNeChpzRiry0YFQdKxRFPV3z3WTc8eG FJtEJ/xlkV1giJ/U8blSzKMTc6JynV0IFZZVc8xhWHxcV9qR2Gf0z5Su/CfQbbfEleDJwT xD4EanjLb4FeB2qoEkq/8opkWNu1xIQ= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-589-E2O43J58MiaMZQaAcrQ5Pg-1; Mon, 05 Jul 2021 13:06:29 -0400 X-MC-Unique: E2O43J58MiaMZQaAcrQ5Pg-1 Received: by mail-ed1-f72.google.com with SMTP id o8-20020aa7dd480000b02903954c05c938so9385024edw.3 for ; Mon, 05 Jul 2021 10:06:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=KuRy89eXRByFxlnTN23uE6bhIohFVEQlDPFd8c6xtSg=; b=WyzuhjZRsCKz3bxF+WZoLUHyD+wFGSeDF5oUZgKvjCwMZciaRXAQVEpp7adYDBoTa8 vobIM1QSBRw9/+/eF9NXNFXZFpNeX/uq8Czcxnl9CCytVpDjICBqp12tHBzHzjdZjFKL 1ZaZjeKtFQr+fkoL4WjkYkaDU/aphah2Bk+83UhmnXqf3hBtjOOzHUMRpXVtsmjxNL7h qWiY79PZxUz9sZrCxT8RTfCxKYu9rfWnkLAabdgFlfaxKRxSVPUIFxttA7xfhgXyB18J Jz+7Hgk3mgDpflJHtPLOHJSs5Q+dp8UwHQkpfsECIvIGacRrm4N6yOsJpnfmPq9t+W7q kpCw== X-Gm-Message-State: AOAM5300+7akVcdm45mN2T/hG1IQcVhsXw06n9R3CFihyyOnZudKlvlj L85+I1cXxjyNosHn2UOTtQmefXGVXjNnQLvJjYFa+U3g+SfVtaK3RFDGXGyeNm9X4MFHOapLk9b 4DK9dV8T7/3Hk X-Received: by 2002:aa7:c352:: with SMTP id j18mr17349729edr.67.1625504788079; Mon, 05 Jul 2021 10:06:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwneJgqJmKUm7lMhmUUKbEhjFjPR6z10Dv09ddqoEicPZlix5wWcSXu7hx55pTRnnUYqwL4+w== X-Received: by 2002:aa7:c352:: with SMTP id j18mr17349702edr.67.1625504787894; Mon, 05 Jul 2021 10:06:27 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id e16sm5842643edr.86.2021.07.05.10.06.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jul 2021 10:06:27 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id BCFB9180639; Mon, 5 Jul 2021 19:06:26 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Maciej Fijalkowski , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net, anthony.l.nguyen@intel.com, kuba@kernel.org, bjorn@kernel.org, magnus.karlsson@intel.com, joamaki@gmail.com, Maciej Fijalkowski Subject: Re: [PATCH v2 intel-next 0/4] XDP_TX improvements for ice In-Reply-To: <20210705164338.58313-1-maciej.fijalkowski@intel.com> References: <20210705164338.58313-1-maciej.fijalkowski@intel.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 05 Jul 2021 19:06:26 +0200 Message-ID: <87sg0sy9kd.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Maciej Fijalkowski writes: > Hi, > > this is a second revision of a series around XDP_TX improvements for ice > driver. When compared to v1 (which can be found under [1]), two new > patches are introduced that are focused on improving the performance for > XDP_TX as Jussi reported that the numbers were pretty low on his side. > Furthermore the fallback path is now based on static branch, as > suggested by Toke on v1. This means that there's no further need for a > standalone net_device_ops that were serving the locked version of > ndo_xdp_xmit callback. > > Idea from 2nd patch is borrowed from a joint work that was done against > OOT driver among with Sridhar Samudrala, Jesse Brandeburg and Piotr > Raczynski, where we working on fixing the scaling issues for Tx AF_XDP > ZC path. > > Last but not least, with this series I observe the improvement of > performance by around 30%. Wow, "but not least" indeed! :D You can't just drop that at the end like that! I want details - whaddyamean, "by around 30%"? In all cases? Only for TX? Gimme numbers! :) -Toke