From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Song Liu <liu.song.a23@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
David Miller <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next 2/6] selftests/bpf: Add tests for automatic map unpinning on load failure
Date: Fri, 08 Nov 2019 21:00:39 +0100 [thread overview]
Message-ID: <87tv7ecf4o.fsf@toke.dk> (raw)
In-Reply-To: <CAPhsuW5stGGGiVH9dSHC4i0kwNcrUhj892DypkfzL=b7woRLvA@mail.gmail.com>
Song Liu <liu.song.a23@gmail.com> writes:
> On Thu, Nov 7, 2019 at 8:52 AM Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>>
>> From: Toke Høiland-Jørgensen <toke@redhat.com>
>>
>> This add tests for the different variations of automatic map unpinning on
>> load failure.
>>
>> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
>> ---
>
> [...]
>
>> diff --git a/tools/testing/selftests/bpf/progs/test_pinning.c b/tools/testing/selftests/bpf/progs/test_pinning.c
>> index f69a4a50d056..f20e7e00373f 100644
>> --- a/tools/testing/selftests/bpf/progs/test_pinning.c
>> +++ b/tools/testing/selftests/bpf/progs/test_pinning.c
>> @@ -21,7 +21,7 @@ struct {
>> } nopinmap SEC(".maps");
>>
>> struct {
>> - __uint(type, BPF_MAP_TYPE_ARRAY);
>> + __uint(type, BPF_MAP_TYPE_HASH);
>
> Why do we need this change?
Because it needs to be different from the top map: I'm changing which of
the maps to use for the "check for parameter mismatch" selftest; the
last map needs to be the one that fails, so that a previous one can
succeed first and get removed on failure clean-up (which we can then
test for)...
-Toke
next prev parent reply other threads:[~2019-11-08 20:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 16:52 [PATCH bpf-next 0/6] libbpf: Fix pinning and error message bugs and add new getters Toke Høiland-Jørgensen
2019-11-07 16:52 ` [PATCH bpf-next 1/6] libbpf: Unpin auto-pinned maps if loading fails Toke Høiland-Jørgensen
2019-11-08 19:27 ` Song Liu
2019-11-07 16:52 ` [PATCH bpf-next 2/6] selftests/bpf: Add tests for automatic map unpinning on load failure Toke Høiland-Jørgensen
2019-11-08 19:33 ` Song Liu
2019-11-08 20:00 ` Toke Høiland-Jørgensen [this message]
2019-11-07 16:52 ` [PATCH bpf-next 3/6] libbpf: Propagate EPERM to caller on program load Toke Høiland-Jørgensen
2019-11-08 19:36 ` Song Liu
2019-11-07 16:52 ` [PATCH bpf-next 4/6] libbpf: Use pr_warn() when printing netlink errors Toke Høiland-Jørgensen
2019-11-08 19:37 ` Song Liu
2019-11-07 16:52 ` [PATCH bpf-next 5/6] libbpf: Add bpf_get_link_xdp_info() function to get more XDP information Toke Høiland-Jørgensen
2019-11-08 19:52 ` Song Liu
2019-11-08 20:04 ` Toke Høiland-Jørgensen
2019-11-07 16:52 ` [PATCH bpf-next 6/6] libbpf: Add getter for program size Toke Høiland-Jørgensen
2019-11-08 19:55 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv7ecf4o.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=liu.song.a23@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).