From: Michael Ellerman <mpe@ellerman.id.au>
To: Vitaly Chikunov <vt@altlinux.org>,
bpf@vger.kernel.org, Will Deacon <will@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Sandipan Das <sandipan@linux.ibm.com>
Cc: "Dmitry V. Levin" <ldv@altlinux.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: tools/bpf: Compilation issue on powerpc: unknown type name '__vector128'
Date: Mon, 26 Oct 2020 15:45:55 +1100 [thread overview]
Message-ID: <87y2jtwq64.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20201024203040.4cjxnxrdy6qx557c@altlinux.org>
Vitaly Chikunov <vt@altlinux.org> writes:
> Adding netdev and PowerPC maintainers JFYI.
Thanks.
> On Sat, Oct 24, 2020 at 11:23:19AM +0300, Dmitry V. Levin wrote:
>> Hi,
>>
>> On Sat, Oct 24, 2020 at 02:06:41AM +0300, Vitaly Chikunov wrote:
>> > Hi,
>> >
>> > Commit f143c11bb7b9 ("tools: bpf: Use local copy of headers including
>> > uapi/linux/filter.h") introduces compilation issue on powerpc:
>> >
>> > builder@powerpc64le:~/linux$ make -C tools/bpf V=1
>> > make: Entering directory '/usr/src/linux/tools/bpf'
>> > gcc -Wall -O2 -D__EXPORTED_HEADERS__ -I/usr/src/linux/tools/include/uapi -I/usr/src/linux/tools/include -DDISASM_FOUR_ARGS_SIGNATURE -c -o bpf_dbg.o /usr/src/linux/tools/bpf/bpf_dbg.c
Defining __EXPORTED_HEADERS__ is a hack to circumvent the checks in the
uapi headers.
So first comment is to stop doing that, although it doesn't actually fix
this issue.
>> > In file included from /usr/include/asm/sigcontext.h:14,
>> > from /usr/include/bits/sigcontext.h:30,
>> > from /usr/include/signal.h:291,
>> > from /usr/src/linux/tools/bpf/bpf_dbg.c:51:
>> > /usr/include/asm/elf.h:160:9: error: unknown type name '__vector128'
>> > 160 | typedef __vector128 elf_vrreg_t;
>> > | ^~~~~~~~~~~
>> > make: *** [Makefile:67: bpf_dbg.o] Error 1
>> > make: Leaving directory '/usr/src/linux/tools/bpf'
>>
>> __vector128 is defined in arch/powerpc/include/uapi/asm/types.h;
>> while include/uapi/linux/types.h does #include <asm/types.h>,
>> tools/include/uapi/linux/types.h doesn't, resulting to this
>> compilation error.
>
> This is too puzzling to fix portably.
I don't really understand how this is expected to work.
We have tools/include/uapi/linux/types.h which is some sort of hand
hacked types.h, but doesn't match the real types.h from
include/uapi/linux.
In particular the tools/include types.h doesn't include asm/types.h,
which is why this breaks.
I can build bpf_dbg if I copy the properly exported header in:
$ make INSTALL_HDR_PATH=$PWD/headers headers_install
$ cp headers/include/linux/types.h tools/include/uapi/linux/
$ make -C tools/bpf bpf_dbg
make: Entering directory '/home/michael/linux/tools/bpf'
Auto-detecting system features:
... libbfd: [ on ]
... disassembler-four-args: [ on ]
CC bpf_dbg.o
LINK bpf_dbg
make: Leaving directory '/home/michael/linux/tools/bpf
I'm not sure what the proper fix is.
Maybe sync the tools/include types.h with the real one?
Or TBH I would have thought the best option is to not have
tools/include/uapi at all, but instead just run headers_install before
building and use the properly exported headers.
cheers
next prev parent reply other threads:[~2020-10-26 4:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 23:06 tools/bpf: Compilation issue on powerpc: unknown type name '__vector128' Vitaly Chikunov
2020-10-24 8:23 ` Dmitry V. Levin
2020-10-24 20:30 ` Vitaly Chikunov
2020-10-26 4:45 ` Michael Ellerman [this message]
2020-10-26 8:46 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2jtwq64.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=acme@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ldv@altlinux.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=sandipan@linux.ibm.com \
--cc=vt@altlinux.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).