From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 966EDC33CB2 for ; Wed, 15 Jan 2020 15:41:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 682202053B for ; Wed, 15 Jan 2020 15:41:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YChF1PjI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728901AbgAOPlT (ORCPT ); Wed, 15 Jan 2020 10:41:19 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:26819 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726165AbgAOPlS (ORCPT ); Wed, 15 Jan 2020 10:41:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579102877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3l69K3PDMlJemoFXpDZpBSROJVwgjnc3IAfTJYLJE1A=; b=YChF1PjIBgiLA7p/y+SytmrB/wC8QtvdcKl8Tq+491wdCkcumPhij+yoTdxraxLV2fS5S5 2pF5PbsK7Fu3qZYDEdMd5SkOXEps6V1ECvFiMjEuAL8bvyogmwlB6ZbcsejdDe8ZljLI1O CYW3gR8Dkb6h/iJJq47HVeskhLONubs= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-Nr2woEVDP0--6Jjp_cI1tw-1; Wed, 15 Jan 2020 10:41:15 -0500 X-MC-Unique: Nr2woEVDP0--6Jjp_cI1tw-1 Received: by mail-lj1-f198.google.com with SMTP id r14so4246272ljc.18 for ; Wed, 15 Jan 2020 07:41:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=3l69K3PDMlJemoFXpDZpBSROJVwgjnc3IAfTJYLJE1A=; b=lRU7FHwJZclUu1ePND+NU1J0fL3MZWXTLxEZoAeclHoY/q17HpCTOWXJ3V6gZCbh0R KCVAxU3xXly4eYZWRttnCcojVFz+vjTuTznpQMHMV93JQ79ZwCh+1BLPyDjQSvp//uDD gUh+8yaE/6iA9zi9bFVDaNiUtxAfzFzFQSQivUMadhPilACDqaDCiTN/OC5tnW1prj22 P9umu1ccEk8tXRlxGvm9qBDECkYVey50W/eM7wrd5Yr/VU5GDAsxK+muNe/m5mT9Eq3o I8jABqzUQQunpVIQDCqkPvhyCLLnq3KkA3MVPM09pgFEYsKF25+tjbjd4re0eGYAhzWb U8TQ== X-Gm-Message-State: APjAAAVg2MdG1jnHvMeqaI/Ywlni9fdOarHQ0wHXCdNg81K4GPsWE3XN hLcYFFUkB8+p1yABmSzknG/P3FvmgBjj0TkjeXWNpHrNz2vnzD05t1rQv+EFpRMkqqMYm/VT4aS kRXJLf725+ohJ X-Received: by 2002:a19:5e0a:: with SMTP id s10mr5018181lfb.165.1579102874418; Wed, 15 Jan 2020 07:41:14 -0800 (PST) X-Google-Smtp-Source: APXvYqyazUrqAH6dclikkhYZ4/DJpUS4QXtSoJ0WpysfA1lHkQWnuS6US8Z0PNCGkK1YfaYA0049DA== X-Received: by 2002:a19:5e0a:: with SMTP id s10mr5018171lfb.165.1579102874260; Wed, 15 Jan 2020 07:41:14 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id s22sm9557271ljm.41.2020.01.15.07.41.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2020 07:41:13 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id DB6C51804D6; Wed, 15 Jan 2020 16:41:12 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jesper Dangaard Brouer Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Doug Ledford , Jason Gunthorpe , "David S. Miller" , Jakub Kicinski , John Fastabend , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Shuah Khan , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kselftest@vger.kernel.org, clang-built-linux@googlegroups.com, brouer@redhat.com Subject: Re: [PATCH bpf-next v2 07/10] samples/bpf: Use consistent include paths for libbpf In-Reply-To: <20200115161825.351ebf23@carbon> References: <157909756858.1192265.6657542187065456112.stgit@toke.dk> <157909757639.1192265.16930011370158657444.stgit@toke.dk> <20200115161825.351ebf23@carbon> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 15 Jan 2020 16:41:12 +0100 Message-ID: <87y2u8u3qf.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Jesper Dangaard Brouer writes: > On Wed, 15 Jan 2020 15:12:56 +0100 > Toke H=C3=B8iland-J=C3=B8rgensen wrote: > >> From: Toke H=C3=B8iland-J=C3=B8rgensen >>=20 >> Fix all files in samples/bpf to include libbpf header files with the bpf/ >> prefix, to be consistent with external users of the library. Also ensure >> that all includes of exported libbpf header files (those that are export= ed >> on 'make install' of the library) use bracketed includes instead of quot= ed. >>=20 >> To make sure no new files are introduced that doesn't include the bpf/ >> prefix in its include, remove tools/lib/bpf from the include path entire= ly, >> and use tools/lib instead. >>=20 >> Fixes: 6910d7d3867a ("selftests/bpf: Ensure bpf_helper_defs.h are taken = from selftests dir") >> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > > I like this change. Maybe the reason so many samples/bpf/ files > still included "libbpf.h" was that once-upon-a-time we had a "eBPF mini > library" in the file samples/bpf/libbpf.h that were included. Yes, I think something similar is the case with bpf_helpers.h - that used to be outside libbpf, and I guess no one bothered to do a cleanup such as this one when it was moved... -Toke