From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B35CC35247 for ; Mon, 3 Feb 2020 20:58:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0EE302087E for ; Mon, 3 Feb 2020 20:58:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725372AbgBCU6B (ORCPT ); Mon, 3 Feb 2020 15:58:01 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:53979 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbgBCU6B (ORCPT ); Mon, 3 Feb 2020 15:58:01 -0500 X-Originating-IP: 79.86.19.127 Received: from [192.168.0.12] (127.19.86.79.rev.sfr.net [79.86.19.127]) (Authenticated sender: alex@ghiti.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 10182E0004; Mon, 3 Feb 2020 20:57:55 +0000 (UTC) Subject: Re: [PATCH bpf-next v2 6/9] riscv, bpf: provide RISC-V specific JIT image alloc/free To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Cc: Daniel Borkmann , Alexei Starovoitov , Netdev , linux-riscv@lists.infradead.org, bpf , Anup Patel , vincent.chen@sifive.com References: <20191216091343.23260-1-bjorn.topel@gmail.com> <20191216091343.23260-7-bjorn.topel@gmail.com> <3f6d3495-efdf-e663-2a84-303fde947a1d@ghiti.fr> From: Alex Ghiti Message-ID: <881b35d6-23ce-fac3-23b8-cdd4d70fa106@ghiti.fr> Date: Mon, 3 Feb 2020 15:57:55 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 2/3/20 7:28 AM, Björn Töpel wrote: > On Sun, 2 Feb 2020 at 14:37, Alex Ghiti wrote: > [...] >> I think it would be better to completely avoid this patch and the >> definition of this >> new zone by using the generic implementation if we had the patch >> discussed here >> regarding modules memory allocation (that in any case we need to fix >> modules loading): >> >> https://lore.kernel.org/linux-riscv/d868acf5-7242-93dc-0051-f97e64dc4387@ghiti.fr/T/#m2be30cb71dc9aa834a50d346961acee26158a238 >> > This patch is already upstream. I agree that when the module > allocation fix is upstream, the BPF image allocation can be folded > into the module allocation. IOW, I wont send any page table dumper > patch for BPF memory. Too late then :) I'll remove this zone with the patch regarding module allocation. > > But keep in mind that the RV BPF JIT relies on having the kernel text > within the 32b range (as does modules) Yep, same constraints as for modules ;) Thanks, Alex > > Cheers, > Björn