bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: "Björn Töpel" <bjorn.topel@gmail.com>,
	ast@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: bjorn.topel@intel.com, maciej.fijalkowski@intel.com,
	hawk@kernel.org, toke@redhat.com, magnus.karlsson@intel.com,
	john.fastabend@gmail.com, kuba@kernel.org, davem@davemloft.net
Subject: Re: [PATCH bpf-next v6 0/2] Optimize bpf_redirect_map()/xdp_do_redirect()
Date: Wed, 10 Mar 2021 01:19:19 +0100	[thread overview]
Message-ID: <8a094161-56fc-e6f6-3108-e5758f3bf977@iogearbox.net> (raw)
In-Reply-To: <20210308112907.559576-1-bjorn.topel@gmail.com>

On 3/8/21 12:29 PM, Björn Töpel wrote:
> Hi XDP-folks,
> 
> This two patch series contain two optimizations for the
> bpf_redirect_map() helper and the xdp_do_redirect() function.
> 
> The bpf_redirect_map() optimization is about avoiding the map lookup
> dispatching. Instead of having a switch-statement and selecting the
> correct lookup function, we let bpf_redirect_map() be a map operation,
> where each map has its own bpf_redirect_map() implementation. This way
> the run-time lookup is avoided.
> 
> The xdp_do_redirect() patch restructures the code, so that the map
> pointer indirection can be avoided.
> 
> Performance-wise I got 4% improvement for XSKMAP
> (sample:xdpsock/rx-drop), and 8% (sample:xdp_redirect_map) on my
> machine.
> 
> @Jesper/@Toke I kept your Acked-by: for patch 2. Let me know, if you
> don't agree with that decision.
> 
> More details in each commit.
> 
> Changelog:
> v5->v6:  Removed REDIR enum, and instead use map_id and map_type. (Daniel)
>           Applied Daniel's fixups on patch 1. (Daniel)
> v4->v5:  Renamed map operation to map_redirect. (Daniel)
> v3->v4:  Made bpf_redirect_map() a map operation. (Daniel)
> v2->v3:  Fix build when CONFIG_NET is not set. (lkp)
> v1->v2:  Removed warning when CONFIG_BPF_SYSCALL was not set. (lkp)
>           Cleaned up case-clause in xdp_do_generic_redirect_map(). (Toke)
>           Re-added comment. (Toke)
> rfc->v1: Use map_id, and remove bpf_clear_redirect_map(). (Toke)
>           Get rid of the macro and use __always_inline. (Jesper)

Applied, thanks!

  parent reply	other threads:[~2021-03-10  0:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 11:29 Björn Töpel
2021-03-08 11:29 ` [PATCH bpf-next v6 1/2] bpf, xdp: make bpf_redirect_map() a map operation Björn Töpel
2021-03-08 11:29 ` [PATCH bpf-next v6 2/2] bpf, xdp: restructure redirect actions Björn Töpel
2021-03-10  0:19 ` Daniel Borkmann [this message]
2021-03-10  0:20 ` [PATCH bpf-next v6 0/2] Optimize bpf_redirect_map()/xdp_do_redirect() patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a094161-56fc-e6f6-3108-e5758f3bf977@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=ast@kernel.org \
    --cc=bjorn.topel@gmail.com \
    --cc=bjorn.topel@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=toke@redhat.com \
    --subject='Re: [PATCH bpf-next v6 0/2] Optimize bpf_redirect_map()/xdp_do_redirect()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).