From: Mukesh Ojha <mojha@codeaurora.org>
To: ast@kernel.org, daniel@iogearbox.net, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, jakub.kicinski@netronome.com,
df@google.com, quentin.monnet@netronome.com,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bpf: bpftool: convert ‘const char *’ type into 'char *' in assignment
Date: Thu, 28 Mar 2019 20:06:06 +0530 [thread overview]
Message-ID: <9846e3b1-1878-990a-61ef-464eb71fe048@codeaurora.org> (raw)
In-Reply-To: <20190328141652.wssqboyekxmp6tkw@yubo-2>
On 3/28/2019 7:46 PM, Bo YU wrote:
> When compiling with check flag: make -C tools/bpf/bpftool/
> gcc will warning:
>
> jit_disasm.c:119:29: warning: assignment discards ‘const’ qualifier
> from pointer target type [-Wdiscarded-qualifiers]
> info.disassembler_options = disassembler_options;
>
> So convert 'const char *' type into 'char *' to fix the warning.
>
> Fixes:3ddeac6705aba(tools: bpftool: use 4 context mode for the NFP
> disasm)
> Signed-off-by: Bo YU <tsu.yubo@gmail.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
-Mukesh
> ---
> tools/bpf/bpftool/jit_disasm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/bpf/bpftool/jit_disasm.c
> b/tools/bpf/bpftool/jit_disasm.c
> index 3ef3093560ba..40b46e46454a 100644
> --- a/tools/bpf/bpftool/jit_disasm.c
> +++ b/tools/bpf/bpftool/jit_disasm.c
> @@ -116,7 +116,7 @@ void disasm_print_insn(unsigned char *image,
> ssize_t len, int opcodes,
> info.arch = bfd_get_arch(bfdf);
> info.mach = bfd_get_mach(bfdf);
> if (disassembler_options)
> - info.disassembler_options = disassembler_options;
> + info.disassembler_options = (char *)disassembler_options;
> info.buffer = image;
> info.buffer_length = len;
>
prev parent reply other threads:[~2019-03-28 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 14:16 [PATCH] bpf: bpftool: convert ‘const char *’ type into 'char *' in assignment Bo YU
2019-03-28 14:30 ` Quentin Monnet
2019-03-28 14:38 ` Bo YU
2019-03-28 15:08 ` David Laight
2019-03-28 15:58 ` Quentin Monnet
2019-03-28 14:36 ` Mukesh Ojha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9846e3b1-1878-990a-61ef-464eb71fe048@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=df@google.com \
--cc=jakub.kicinski@netronome.com \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quentin.monnet@netronome.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).