From: Yonghong Song <yhs@fb.com>
To: Qais Yousef <qais.yousef@arm.com>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Steven Rostedt <rostedt@goodmis.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next 1/2] trace: bpf: Allow bpf to attach to bare tracepoints
Date: Wed, 13 Jan 2021 08:06:03 -0800 [thread overview]
Message-ID: <98738d92-7679-5ed2-71c8-1ba71d7cac6e@fb.com> (raw)
In-Reply-To: <20210113101606.lpsn4scnsecdfxwr@e107158-lin>
On 1/13/21 2:16 AM, Qais Yousef wrote:
> On 01/12/21 12:19, Yonghong Song wrote:
>> I applied the patch to my local bpf-next repo, and got the following
>> compilation error:
>
> [...]
>
>>
>> I dumped preprecessor result but after macro expansion, the code
>> becomes really complex and I have not figured out why it failed.
>> Do you know what is the possible reason?
>
> Yeah I did a last minute fix to address a checkpatch.pl error and my
> verification of the change wasn't good enough obviously.
>
> If you're keen to try out I can send you a patch with the fix. I should send v2
> by the weekend too.
Thanks. I can wait and will check v2 once it is available.
>
> Thanks for having a look.
>
> Cheers
>
> --
> Qais Yousef
>
next prev parent reply other threads:[~2021-01-13 16:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 18:20 [PATCH bpf-next 0/2] Allow attaching to bare tracepoints Qais Yousef
2021-01-11 18:20 ` [PATCH bpf-next 1/2] trace: bpf: Allow bpf to attach " Qais Yousef
2021-01-12 20:19 ` Yonghong Song
2021-01-13 10:16 ` Qais Yousef
2021-01-13 16:06 ` Yonghong Song [this message]
2021-01-14 2:59 ` kernel test robot
2021-01-14 3:46 ` kernel test robot
2021-01-11 18:20 ` [PATCH bpf-next 2/2] selftests: bpf: Add a new test for " Qais Yousef
2021-01-12 7:26 ` Andrii Nakryiko
2021-01-12 19:27 ` Qais Yousef
2021-01-12 20:07 ` Andrii Nakryiko
2021-01-13 10:21 ` Qais Yousef
2021-01-13 16:40 ` Jean-Philippe Brucker
2021-01-14 12:58 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98738d92-7679-5ed2-71c8-1ba71d7cac6e@fb.com \
--to=yhs@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).