From: Yonghong Song <yhs@fb.com>
To: YiFei Zhu <zhuyifei@google.com>
Cc: YiFei Zhu <zhuyifei1999@gmail.com>, <bpf@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Stanislav Fomichev <sdf@google.com>,
Mahesh Bandewar <maheshb@google.com>
Subject: Re: [PATCH bpf-next 3/5] libbpf: Add BPF_PROG_BIND_MAP syscall and use it on .metadata section
Date: Fri, 21 Aug 2020 08:14:15 -0700 [thread overview]
Message-ID: <98fe7ba3-a15b-7414-39f2-8a2243132726@fb.com> (raw)
In-Reply-To: <CAA-VZPm_4q=nkx2PaawtdpesqJSMQdziNwV5=t3zgW8WM6Q9kw@mail.gmail.com>
On 8/21/20 12:52 AM, YiFei Zhu wrote:
> On Thu, Aug 20, 2020 at 3:38 PM Yonghong Song <yhs@fb.com> wrote:
>>
>>> + int fd = ret;
>>> +
>>> + ret = -errno;
>>
>> libbpf_strerror_r understands positive and negative errno, so no need
>> "ret = -errno".
>
> I don't understand this one. The use of ret = -errno here is that when
> we goto out later we return a -errno. If this line is removed then fd
> is returned after fd is closed, in the case of a bind map failure,
> without writing to *pfd. Am I misunderstanding something?
Aha, sorry. My bad. I missed that 'ret' is used later for the negative
code return value. Yes, your code looks fine.
>
> YiFei Zhu
>
next prev parent reply other threads:[~2020-08-21 15:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 9:42 [PATCH bpf-next 0/5] Allow storage of flexible metadata information for eBPF programs YiFei Zhu
2020-08-20 9:42 ` [PATCH bpf-next 1/5] bpf: Mutex protect used_maps array and count YiFei Zhu
2020-08-20 21:18 ` Yonghong Song
2020-08-20 9:42 ` [PATCH bpf-next 2/5] bpf: Add BPF_PROG_BIND_MAP syscall YiFei Zhu
2020-08-20 21:23 ` Yonghong Song
2020-08-20 9:42 ` [PATCH bpf-next 3/5] libbpf: Add BPF_PROG_BIND_MAP syscall and use it on .metadata section YiFei Zhu
2020-08-20 20:38 ` Yonghong Song
2020-08-21 7:52 ` YiFei Zhu
2020-08-21 15:14 ` Yonghong Song [this message]
2020-08-25 20:45 ` Andrey Ignatov
2020-08-26 4:02 ` Andrii Nakryiko
2020-08-20 9:42 ` [PATCH bpf-next 4/5] bpftool: support dumping metadata YiFei Zhu
2020-08-20 21:11 ` Yonghong Song
2020-08-21 8:58 ` Toke Høiland-Jørgensen
2020-08-21 20:10 ` YiFei Zhu
2020-08-23 18:36 ` Toke Høiland-Jørgensen
2020-08-28 17:00 ` sdf
2020-08-28 20:55 ` Toke Høiland-Jørgensen
2020-08-26 5:36 ` Andrii Nakryiko
2020-08-28 16:59 ` sdf
2020-09-03 5:18 ` Andrii Nakryiko
2020-08-20 9:42 ` [PATCH bpf-next 5/5] selftests/bpf: Test bpftool loading and " YiFei Zhu
2020-08-20 21:15 ` Yonghong Song
2020-08-26 4:00 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98fe7ba3-a15b-7414-39f2-8a2243132726@fb.com \
--to=yhs@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=maheshb@google.com \
--cc=sdf@google.com \
--cc=zhuyifei1999@gmail.com \
--cc=zhuyifei@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).