From: Daniel Borkmann <daniel@iogearbox.net>
To: Jakub Sitnicki <jakub@cloudflare.com>, bpf@vger.kernel.org
Cc: netdev@vger.kernel.org, kernel-team@cloudflare.com,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Stanislav Fomichev <sdf@google.com>
Subject: Re: [PATCH bpf-next v2 0/3] bpf, netns: Prepare for multi-prog attachment
Date: Mon, 29 Jun 2020 16:56:55 +0200 [thread overview]
Message-ID: <9b9f413c-fa55-2fd9-a6d8-12e434a2b603@iogearbox.net> (raw)
In-Reply-To: <20200623103459.697774-1-jakub@cloudflare.com>
On 6/23/20 12:34 PM, Jakub Sitnicki wrote:
> This patch set prepares ground for link-based multi-prog attachment for
> future netns attach types, with BPF_SK_LOOKUP attach type in mind [0].
>
> Two changes are needed in order to attach and run a series of BPF programs:
>
> 1) an bpf_prog_array of programs to run (patch #2), and
> 2) a list of attached links to keep track of attachments (patch #3).
>
> I've been using these patches with the next iteration of BPF socket lookup
> hook patches, and saw that they are self-contained and can be split out to
> ease the review burden.
>
> Nothing changes for BPF flow_dissector. That is at most one prog can be
> attached.
>
> Thanks,
> -jkbs
>
> [0] https://lore.kernel.org/bpf/20200511185218.1422406-1-jakub@cloudflare.com/
>
> Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>
> Cc: Stanislav Fomichev <sdf@google.com>
>
> v1 -> v2:
>
> - Show with a (void) cast that bpf_prog_array_replace_item() return value
> is ignored on purpose. (Andrii)
> - Explain why bpf-cgroup cannot replace programs in bpf_prog_array based
> on bpf_prog pointer comparison in patch #2 description. (Andrii)
>
> Jakub Sitnicki (3):
> flow_dissector: Pull BPF program assignment up to bpf-netns
> bpf, netns: Keep attached programs in bpf_prog_array
> bpf, netns: Keep a list of attached bpf_link's
>
> include/linux/bpf.h | 3 +
> include/net/flow_dissector.h | 3 +-
> include/net/netns/bpf.h | 7 +-
> kernel/bpf/core.c | 20 +++-
> kernel/bpf/net_namespace.c | 189 +++++++++++++++++++++++++----------
> net/core/flow_dissector.c | 34 +++----
> 6 files changed, 173 insertions(+), 83 deletions(-)
>
Applied, thanks!
next prev parent reply other threads:[~2020-06-29 19:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 10:34 [PATCH bpf-next v2 0/3] bpf, netns: Prepare for multi-prog attachment Jakub Sitnicki
2020-06-23 10:34 ` [PATCH bpf-next v2 1/3] flow_dissector: Pull BPF program assignment up to bpf-netns Jakub Sitnicki
2020-06-23 10:34 ` [PATCH bpf-next v2 2/3] bpf, netns: Keep attached programs in bpf_prog_array Jakub Sitnicki
2020-06-23 19:33 ` Martin KaFai Lau
2020-06-23 20:59 ` Jakub Sitnicki
2020-06-23 21:24 ` Martin KaFai Lau
2020-06-24 17:33 ` Jakub Sitnicki
2020-06-24 17:18 ` Jakub Sitnicki
2020-06-24 17:47 ` Andrii Nakryiko
2020-06-24 18:13 ` Jakub Sitnicki
2020-06-24 18:24 ` Andrii Nakryiko
2020-06-24 18:37 ` Jakub Sitnicki
2020-06-23 10:34 ` [PATCH bpf-next v2 3/3] bpf, netns: Keep a list of attached bpf_link's Jakub Sitnicki
2020-06-29 14:56 ` Daniel Borkmann [this message]
2020-06-29 14:57 ` [PATCH bpf-next v2 0/3] bpf, netns: Prepare for multi-prog attachment Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b9f413c-fa55-2fd9-a6d8-12e434a2b603@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=jakub@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).