From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5248CC33CAD for ; Mon, 13 Jan 2020 12:31:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22E962081E for ; Mon, 13 Jan 2020 12:31:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726074AbgAMMbm (ORCPT ); Mon, 13 Jan 2020 07:31:42 -0500 Received: from mga06.intel.com ([134.134.136.31]:2101 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbgAMMbm (ORCPT ); Mon, 13 Jan 2020 07:31:42 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 04:31:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,428,1571727600"; d="scan'208";a="273017199" Received: from arydygie-mobl.ger.corp.intel.com (HELO btopel-mobl.ger.intel.com) ([10.252.51.144]) by FMSMGA003.fm.intel.com with ESMTP; 13 Jan 2020 04:31:39 -0800 Subject: Re: [PATCH 5/5] bpf: Allow to resolve bpf trampoline in unwind From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= To: Jiri Olsa Cc: Alexei Starovoitov , Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, bpf@vger.kernel.org, Andrii Nakryiko , Yonghong Song , Martin KaFai Lau , Jakub Kicinski , David Miller References: <20191229143740.29143-1-jolsa@kernel.org> <20191229143740.29143-6-jolsa@kernel.org> <20200106234639.fo2ctgkb5vumayyl@ast-mbp> <20200107130546.GI290055@krava> <76a10338-391a-ffca-9af8-f407265d146a@intel.com> <20200113094310.GE35080@krava> Message-ID: <9da1c8f9-7ca5-e10b-8931-6871fdbffb23@intel.com> Date: Mon, 13 Jan 2020 13:31:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 2020-01-13 13:21, Björn Töpel wrote: > > On 2020-01-13 10:43, Jiri Olsa wrote: >> hi, >> attached patch seems to work for me (trampoline usecase), but I don't >> know >> how to test it for dispatcher.. also I need to check if we need to >> decrease >> BPF_TRAMP_MAX or BPF_DISPATCHER_MAX, it might take more time;-) >> > > Thanks for working on it! I'll take the patch for a spin. > > To test the dispatcher, just run XDP! > > With your change, the BPF_DISPATCHER_MAX is still valid. 48 entries => > 1890B which is < (BPF_IMAGE_SIZE / 2). > ...and FWIW, it would be nice with bpf_dispatcher_<...> entries in kallsyms as well. If that code could be shared with the trampoline code as well (bpf_trampoline_), that'd be great!