From: Song Liu <songliubraving@fb.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"andrii.nakryiko@gmail.com" <andrii.nakryiko@gmail.com>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v4 bpf-next 1/4] bpf: switch bpf_map ref counter to 64bit so bpf_map_inc never fails
Date: Fri, 15 Nov 2019 21:47:56 +0000 [thread overview]
Message-ID: <AAF69EA9-C7B3-4EB1-BF5B-556EAB2E4DF1@fb.com> (raw)
In-Reply-To: <20191115040225.2147245-2-andriin@fb.com>
> On Nov 14, 2019, at 8:02 PM, Andrii Nakryiko <andriin@fb.com> wrote:
>
[...]
>
> This patch, while modifying all users of bpf_map_inc, also cleans up its
> interface to match bpf_map_put with separate operations for bpf_map_inc and
> bpf_map_inc_with_uref (to match bpf_map_put and bpf_map_put_with_uref,
> respectively). Also, given there are no users of bpf_map_inc_not_zero
> specifying uref=true, remove uref flag and default to uref=false internally.
>
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Acked-by: Song Liu <songliubraving@fb.com>
next prev parent reply other threads:[~2019-11-15 21:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 4:02 [PATCH v4 bpf-next 0/4] Add support for memory-mapping BPF array maps Andrii Nakryiko
2019-11-15 4:02 ` [PATCH v4 bpf-next 1/4] bpf: switch bpf_map ref counter to 64bit so bpf_map_inc never fails Andrii Nakryiko
2019-11-15 21:47 ` Song Liu [this message]
2019-11-15 23:23 ` Daniel Borkmann
2019-11-15 23:27 ` Andrii Nakryiko
2019-11-15 4:02 ` [PATCH v4 bpf-next 2/4] bpf: add mmap() support for BPF_MAP_TYPE_ARRAY Andrii Nakryiko
2019-11-15 4:45 ` Alexei Starovoitov
2019-11-15 5:05 ` Andrii Nakryiko
2019-11-15 5:08 ` Alexei Starovoitov
2019-11-15 5:43 ` Andrii Nakryiko
2019-11-15 16:36 ` Andrii Nakryiko
2019-11-15 20:42 ` Jakub Kicinski
2019-11-15 13:57 ` Johannes Weiner
2019-11-15 23:31 ` Daniel Borkmann
2019-11-15 23:37 ` Alexei Starovoitov
2019-11-15 23:44 ` Daniel Borkmann
2019-11-15 23:47 ` Alexei Starovoitov
2019-11-16 0:13 ` Daniel Borkmann
2019-11-16 1:18 ` Alexei Starovoitov
2019-11-17 5:57 ` Andrii Nakryiko
2019-11-17 12:07 ` Daniel Borkmann
2019-11-17 17:17 ` Andrii Nakryiko
2019-11-18 13:50 ` Daniel Borkmann
2019-11-15 4:02 ` [PATCH v4 bpf-next 3/4] libbpf: make global data internal arrays mmap()-able, if possible Andrii Nakryiko
2019-11-15 4:02 ` [PATCH v4 bpf-next 4/4] selftests/bpf: add BPF_TYPE_MAP_ARRAY mmap() tests Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AAF69EA9-C7B3-4EB1-BF5B-556EAB2E4DF1@fb.com \
--to=songliubraving@fb.com \
--cc=Kernel-team@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).