From: "Daniel Xu" <dxu@dxuuu.xyz>
To: "John Fastabend" <john.fastabend@gmail.com>,
<bpf@vger.kernel.org>, <ast@kernel.org>, <daniel@iogearbox.net>,
<songliubraving@fb.com>, <yhs@fb.com>, <andriin@fb.com>
Cc: "Daniel Xu" <dxu@dxuuu.xyz>, <linux-kernel@vger.kernel.org>,
<kernel-team@fb.com>, <peterz@infradead.org>, <mingo@redhat.com>,
<acme@kernel.org>
Subject: RE: [PATCH v2 bpf-next 1/3] bpf: Add bpf_perf_prog_read_branches() helper
Date: Thu, 23 Jan 2020 12:09:51 -0800 [thread overview]
Message-ID: <C03FZ2ZXKIY9.21PQ3FP3MQYU7@dlxu-fedora-R90QNFJV> (raw)
In-Reply-To: <5e293189e298d_1bc42ab516c865b8a1@john-XPS-13-9370.notmuch>
Hi John, thanks for looking.
On Wed Jan 22, 2020 at 9:39 PM, John Fastabend wrote:
[...]
> > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> > index 033d90a2282d..7350c5be6158 100644
> > --- a/include/uapi/linux/bpf.h
> > +++ b/include/uapi/linux/bpf.h
> > @@ -2885,6 +2885,16 @@ union bpf_attr {
> > * **-EPERM** if no permission to send the *sig*.
> > *
> > * **-EAGAIN** if bpf program can try again.
> > + *
> > + * int bpf_perf_prog_read_branches(struct bpf_perf_event_data *ctx, void *buf, u32 buf_size)
> > + * Description
> > + * For en eBPF program attached to a perf event, retrieve the
> > + * branch records (struct perf_branch_entry) associated to *ctx*
> > + * and store it in the buffer pointed by *buf* up to size
> > + * *buf_size* bytes.
>
>
> It seems extra bytes in buf will be cleared. The number of bytes
> copied is returned so I don't see any reason to clear the extra bytes I
> would
> just let the BPF program do this if they care. But it should be noted in
> the description at least.
In include/linux/bpf.h:
/* the following constraints used to prototype bpf_memcmp() and other
* functions that access data on eBPF program stack
*/
ARG_PTR_TO_UNINIT_MEM, /* pointer to memory does not need to be initialized,
* helper function must fill all bytes or clear
* them in error case.
*/
I figured it would be good to clear out the stack b/c this helper
writes data on program stack.
Also bpf_perf_prog_read_value() does something similar (fill zeros on
failure).
[...]
> > + to_copy = min_t(u32, br_stack->nr * sizeof(struct perf_branch_entry), size);
> > + to_clear -= to_copy;
> > +
> > + memcpy(buf, br_stack->entries, to_copy);
> > + err = to_copy;
> > +clear:
> > + memset(buf + to_copy, 0, to_clear);
>
>
> Here, why do this at all? If the user cares they can clear the bytes
> directly from the BPF program. I suspect its probably going to be
> wasted work in most cases. If its needed for some reason provide
> a comment with it.
Same concern as above, right?
I can send a V3 with updated uapi/linux/bpf.h description (and a rebase).
Thanks,
Daniel
next prev parent reply other threads:[~2020-01-23 20:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 20:22 [PATCH v2 bpf-next 0/3] Add bpf_perf_prog_read_branches() helper Daniel Xu
2020-01-22 20:22 ` [PATCH v2 bpf-next 1/3] bpf: " Daniel Xu
2020-01-23 5:39 ` John Fastabend
2020-01-23 20:09 ` Daniel Xu [this message]
2020-01-23 22:23 ` Daniel Borkmann
2020-01-23 22:30 ` Daniel Xu
2020-01-23 22:41 ` Andrii Nakryiko
2020-01-23 23:09 ` Daniel Borkmann
2020-01-23 22:44 ` Daniel Borkmann
2020-01-23 23:07 ` Martin Lau
2020-01-23 23:27 ` Daniel Xu
2020-01-22 20:22 ` [PATCH v2 bpf-next 2/3] tools/bpf: Sync uapi header bpf.h Daniel Xu
2020-01-22 20:22 ` [PATCH v2 bpf-next 3/3] selftests/bpf: add bpf_perf_prog_read_branches() selftest Daniel Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C03FZ2ZXKIY9.21PQ3FP3MQYU7@dlxu-fedora-R90QNFJV \
--to=dxu@dxuuu.xyz \
--cc=acme@kernel.org \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).