From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2492C47420 for ; Tue, 29 Sep 2020 23:53:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 544D8206D8 for ; Tue, 29 Sep 2020 23:53:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Reg+DZTy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729695AbgI2Xx3 (ORCPT ); Tue, 29 Sep 2020 19:53:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729477AbgI2XxX (ORCPT ); Tue, 29 Sep 2020 19:53:23 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7669C0613D0 for ; Tue, 29 Sep 2020 16:53:21 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id p15so88546ejm.7 for ; Tue, 29 Sep 2020 16:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t1rtshaSfQyMQT+kzX63bayjFTAmMlt0jI9IFlUPylY=; b=Reg+DZTyVyvCf3PKzlSNKgWpuXbvt3T6g81qJpZzJTaAOok0wMUXtAheoN8eBysMIb x4FfD41wAmIR6HazZQNbvU1nmTGhhF8kxvarhPEJYAZUAXdbWujfcDbpPiUzlGIYffT1 f/5Ahus+rAZQT23f32gFg8WHnJrHsGNG6LTIicdrSoP5PqMhFeC+ydE+B9IfJ8qxgBKA yt1VVGKSE39oq01hPgGCO44yL4jY0xSiGU4VLymSDRKctb/rx6jxLepQA6q2em80/5CW DBpKlOGkFi1MuWpIhCIXxau0U3ekBXoERqWCHh9AvKGz9cGcfUtAQIHZG+W/R4GU37TB ky3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t1rtshaSfQyMQT+kzX63bayjFTAmMlt0jI9IFlUPylY=; b=gDudHb57ixnwglmlFQHqHuXu1SBGHNJvAbC05PEShy0l5f9m7i7TKEofYsdi3jbvMp g5rUSnGsndQhP7sWgs2UuBt6KnbpEHkvjWiMvKpz0nHX7cc7ejfHseDtvg0KdqgX2ey2 aWCsiLd7RxudwM9xPmMCjXrzwC3DJ0Fa6A1aF6gXB96z5JHa6HR7ny9+CvFIuAPreocg XvN0CMWmJacnA+LJa6erMesuw0Wn1YU7ZcJSO1GfMKvOAy6wj77fnnuGSuOJgQQApulA xWpxIQwyuA4XruSe1eO0WJiQZEjy7r/QAEL0c1fOzn1Oj1Wu16DxOA0mc+b48k6Zzr/p MytA== X-Gm-Message-State: AOAM5335jTEdB3FtZTwJ0buPv2sj/OAyzdix6412EJjweTnh9QgEJjEY fDUkOF0AS2NIL2zpDAW0Pej/3zE9C5iucF05jMjrD/XKOu05vYTH X-Google-Smtp-Source: ABdhPJwX1i8ss2VyW9+uCkdkh3uG4vD+jbxETbbqRBwCd0k3VuxCQE93UdhgF9pmN4t5dbOYxZ0ZecQJc7jg4A2uAxI= X-Received: by 2002:a17:907:110f:: with SMTP id qu15mr82909ejb.359.1601423600125; Tue, 29 Sep 2020 16:53:20 -0700 (PDT) MIME-Version: 1.0 References: <20200916223512.2885524-5-haoluo@google.com> <202009170943.rYEs5XMN%lkp@intel.com> In-Reply-To: From: Hao Luo Date: Tue, 29 Sep 2020 16:53:09 -0700 Message-ID: Subject: Re: [PATCH bpf-next v3 4/6] bpf: Introduce bpf_per_cpu_ptr() To: Andrii Nakryiko Cc: kernel test robot , Networking , bpf , open list , "open list:KERNEL SELFTEST FRAMEWORK" , kbuild-all@lists.01.org, Shuah Khan , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Martin KaFai Lau , Song Liu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Sep 21, 2020 at 11:11 AM Andrii Nakryiko wrote: > > On Thu, Sep 17, 2020 at 12:14 PM Hao Luo wrote: > > > > I need to cast the pointer to "const void __percpu *" before passing > > into per_cpu_ptr. I will update and resend. > > You can try just declaring it as __percpu in BPF_CALL_2 macro. That > might work, or not, depending on how exactly BPF_CALL macros are > implemented (I haven't checked). > ACK. IMO it's probably better cast inside, rather than depending on BPF_CALL macros. The parameters are not true percpu pointers anyway and potential changes on BPF_CALL may break this, I'm afraid. > > > > On Wed, Sep 16, 2020 at 6:14 PM kernel test robot wrote: > > > > > > Hi Hao, > > > > > > Thank you for the patch! Perhaps something to improve: > > > > > > [auto build test WARNING on bpf-next/master] > > > > > > url: https://github.com/0day-ci/linux/commits/Hao-Luo/bpf-BTF-support-for-ksyms/20200917-064052 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > > > config: powerpc-randconfig-s032-20200916 (attached as .config) > > > compiler: powerpc64-linux-gcc (GCC) 9.3.0 > > > reproduce: > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # apt-get install sparse > > > # sparse version: v0.6.2-201-g24bdaac6-dirty > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=powerpc > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > > > > > > > sparse warnings: (new ones prefixed by >>) > > > > > > >> kernel/bpf/helpers.c:631:31: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got void const * @@ > > > >> kernel/bpf/helpers.c:631:31: sparse: expected void const [noderef] __percpu *__vpp_verify > > > >> kernel/bpf/helpers.c:631:31: sparse: got void const * > > > > > > # https://github.com/0day-ci/linux/commit/3f6ea3c1c73efe466a96ff7499219fe3b03b8f48 > > > git remote add linux-review https://github.com/0day-ci/linux > > > git fetch --no-tags linux-review Hao-Luo/bpf-BTF-support-for-ksyms/20200917-064052 > > > git checkout 3f6ea3c1c73efe466a96ff7499219fe3b03b8f48 > > > vim +631 kernel/bpf/helpers.c > > > > > > 625 > > > 626 BPF_CALL_2(bpf_per_cpu_ptr, const void *, ptr, u32, cpu) > > > 627 { > > > 628 if (cpu >= nr_cpu_ids) > > > 629 return (unsigned long)NULL; > > > 630 > > > > 631 return (unsigned long)per_cpu_ptr(ptr, cpu); > > > 632 } > > > 633 > > > 634 const struct bpf_func_proto bpf_per_cpu_ptr_proto = { > > > 635 .func = bpf_per_cpu_ptr, > > > 636 .gpl_only = false, > > > 637 .ret_type = RET_PTR_TO_MEM_OR_BTF_ID_OR_NULL, > > > 638 .arg1_type = ARG_PTR_TO_PERCPU_BTF_ID, > > > 639 .arg2_type = ARG_ANYTHING, > > > 640 }; > > > 641 > > > > 642 const struct bpf_func_proto bpf_get_current_task_proto __weak; > > > 643 const struct bpf_func_proto bpf_probe_read_user_proto __weak; > > > 644 const struct bpf_func_proto bpf_probe_read_user_str_proto __weak; > > > 645 const struct bpf_func_proto bpf_probe_read_kernel_proto __weak; > > > 646 const struct bpf_func_proto bpf_probe_read_kernel_str_proto __weak; > > > 647 > > > > > > --- > > > 0-DAY CI Kernel Test Service, Intel Corporation > > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org