From: YiFei Zhu <zhuyifei@google.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
kernel-team@fb.com
Subject: Re: [PATCH bpf-next] selftests/bpf: don't destroy failed link
Date: Wed, 29 Jul 2020 00:30:52 -0500 [thread overview]
Message-ID: <CAA-VZPnQ36VyK-qEhQXhuyNGBkFqpuM4NMSifix3wfm-CpV=tw@mail.gmail.com> (raw)
In-Reply-To: <20200729045056.3363921-1-andriin@fb.com>
On Tue, Jul 28, 2020 at 11:51 PM Andrii Nakryiko <andriin@fb.com> wrote:
>
> Check that link is NULL or proper pointer before invoking bpf_link__destroy().
> Not doing this causes crash in test_progs, when cg_storage_multi selftest
> fails.
>
> Cc: YiFei Zhu <zhuyifei@google.com>
> Fixes: 3573f384014f ("selftests/bpf: Test CGROUP_STORAGE behavior on shared egress + ingress")
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
> ---
> .../bpf/prog_tests/cg_storage_multi.c | 42 ++++++++++++-------
> 1 file changed, 28 insertions(+), 14 deletions(-)
>
Awesome! Thanks for the fix. I did not realize the return was a -errno
rather than NULL like open_and_load.
next prev parent reply other threads:[~2020-07-29 5:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 4:50 [PATCH bpf-next] selftests/bpf: don't destroy failed link Andrii Nakryiko
2020-07-29 5:30 ` YiFei Zhu [this message]
2020-07-29 5:47 ` Song Liu
2020-07-29 6:16 ` Andrii Nakryiko
2020-07-29 23:12 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA-VZPnQ36VyK-qEhQXhuyNGBkFqpuM4NMSifix3wfm-CpV=tw@mail.gmail.com' \
--to=zhuyifei@google.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).