From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C1CEC433E0 for ; Tue, 9 Jun 2020 18:19:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09CBC2083B for ; Tue, 9 Jun 2020 18:19:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LZqbSx12" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730749AbgFISTM (ORCPT ); Tue, 9 Jun 2020 14:19:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388847AbgFISTK (ORCPT ); Tue, 9 Jun 2020 14:19:10 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 635B0C05BD1E; Tue, 9 Jun 2020 11:19:10 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id u16so13080263lfl.8; Tue, 09 Jun 2020 11:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8czp2mGud/X9y8SyDAs2+lXPkjmhftyAJy2rrCLMh7w=; b=LZqbSx12x35LLKdUmVUSmHuoMheWg3Tm+NXcuDzeepDPMMH0UCb1N2L0jyxK7TbyvI E35VVaQ+Z7Y38/aPC0+UHNVxS4jRMHme7YMCO4pz35HgHeWU22fJ2hv0mN/+K8S5slfy k9Vyi2qYFLBDFPbfCG4YiilDap4zxInhhtLj4xAm3ykX5qgTORMmJ0NwzK4VLNv2htaL 8g7Bo4+teHW84V4Wlc4kN/Oq42hyjd2xfsQm95cka7tas9lGp7wJYMEJc1PdYWCyO1mC e1TirmSj/ilv70OZaQleZsWp6YgGn9fL45zoppLglrp/HbaljykhJhq6x6Q01AlwmgdB kxfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8czp2mGud/X9y8SyDAs2+lXPkjmhftyAJy2rrCLMh7w=; b=HOOexHso2/EgosGz0RPkon8u9+wUERTYETy/9vU5X4eVsVFmD024AZhYM+DAbTtD7R 5YvtY2dyLtTlMI0YQMirO1OQlrhaBGltRqyNEiUXQeSuWWn2HP6hyGj97zD0fSlBl2wz O0VVXRwgqfgI0gZxT6apJsFyUYhm0D6Lo3rPWtbEF9U05QuRoLyWI1lqmysjohJXClXN ACsG5VSyYrF7tZg/tu1iuEWWkkmGS0nxDh3NC9pPI5EO8+aQhV5QxQVwremkuoehCXDC OKaF5+fyiM0cy8qYOHFEQtn2sS9Mjoq2gjW10STGrbZgL91Z8BHW1MbqFqOnlC6gkQAO AQcw== X-Gm-Message-State: AOAM533n3TSfgPpJtDrU/evgZIwui7MG+GcM/b/vYrZsx6I70hoUWPGG SvgBE/F7fjMw9PnWH/moRZ+Qm7JUDwExG9qEwaU= X-Google-Smtp-Source: ABdhPJwJgkr+goe4IPDGLuPCQCuWqxBkd3MNiQkky0sI9TT2JC0L2pk6zNTvXPm+sziwRZVmsDOUBgsnUMR4Fp0WY4U= X-Received: by 2002:a19:987:: with SMTP id 129mr16215034lfj.8.1591726748546; Tue, 09 Jun 2020 11:19:08 -0700 (PDT) MIME-Version: 1.0 References: <20200608124531.819838-1-jean-philippe@linaro.org> <20200609161234.c0b1460e6a6ce73ba478a22a@kernel.org> In-Reply-To: <20200609161234.c0b1460e6a6ce73ba478a22a@kernel.org> From: Alexei Starovoitov Date: Tue, 9 Jun 2020 11:18:57 -0700 Message-ID: Subject: Re: [PATCH] tracing/probe: Fix bpf_task_fd_query() for kprobes and uprobes To: Masami Hiramatsu Cc: Jean-Philippe Brucker , LKML , bpf , Steven Rostedt , Ingo Molnar , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Jun 9, 2020 at 12:12 AM Masami Hiramatsu wrote: > > On Mon, 8 Jun 2020 14:45:32 +0200 > Jean-Philippe Brucker wrote: > > > Commit 60d53e2c3b75 ("tracing/probe: Split trace_event related data from > > trace_probe") removed the trace_[ku]probe structure from the > > trace_event_call->data pointer. As bpf_get_[ku]probe_info() were > > forgotten in that change, fix them now. These functions are currently > > only used by the bpf_task_fd_query() syscall handler to collect > > information about a perf event. > > > > Oops, good catch! > > Acked-by: Masami Hiramatsu > > > > Fixes: 60d53e2c3b75 ("tracing/probe: Split trace_event related data from trace_probe") > > Signed-off-by: Jean-Philippe Brucker > > Cc: stable@vger.kernel.org Applied to bpf tree. Thanks