From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Yonghong Song <yhs@fb.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Daniel Borkmann <daniel@iogearbox.net>,
Network Development <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next] bpf: Add bpf_prog iterator
Date: Wed, 15 Jul 2020 16:56:10 -0700 [thread overview]
Message-ID: <CAADnVQ+Tc30JvwjZ-sbmmViMyaCb3HAS9f4RQ8utjfS8FnLOOw@mail.gmail.com> (raw)
In-Reply-To: <e348c97b-bd8c-c24f-9287-f1c5341ddd4d@fb.com>
On Wed, Jul 1, 2020 at 10:23 PM Yonghong Song <yhs@fb.com> wrote:
>
>
>
> On 7/1/20 6:40 PM, Alexei Starovoitov wrote:
> > From: Alexei Starovoitov <ast@kernel.org>
> >
> > It's mostly a copy paste of commit 6086d29def80 ("bpf: Add bpf_map iterator")
> > that is use to implement bpf_seq_file opreations to traverse all bpf programs.
>
> Thanks for implementing bpf iter for bpf_progs!
>
> >
> > Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> > ---
> > No selftests?!
> > They're coming as part of "usermode_driver for iterators" set.
> > This patch is trivial and independent, so sending it first.
>
> Okay. Ack only with a few nits.
> Acked-by: Yonghong Song <yhs@fb.com>
Thanks for the review. Will be fixed in the next version.
prev parent reply other threads:[~2020-07-15 23:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 1:40 [PATCH bpf-next] bpf: Add bpf_prog iterator Alexei Starovoitov
2020-07-02 5:23 ` Yonghong Song
2020-07-15 23:56 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQ+Tc30JvwjZ-sbmmViMyaCb3HAS9f4RQ8utjfS8FnLOOw@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).