bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Martin Lau <kafai@fb.com>
Cc: Jakub Sitnicki <jakub@cloudflare.com>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"kernel-team@cloudflare.com" <kernel-team@cloudflare.com>
Subject: Re: [PATCH bpf-next 00/10] Switch reuseport tests for test_progs framework
Date: Fri, 13 Dec 2019 12:41:23 -0800	[thread overview]
Message-ID: <CAADnVQ+_4gCavtPnArq3RMWB4ZQNefEZeBMft8+6aSXJqwSAeA@mail.gmail.com> (raw)
In-Reply-To: <20191213163035.res63motipcpkbqz@kafai-mbp>

On Fri, Dec 13, 2019 at 8:31 AM Martin Lau <kafai@fb.com> wrote:
>
> On Thu, Dec 12, 2019 at 09:36:36PM -0800, Alexei Starovoitov wrote:
> > On Thu, Dec 12, 2019 at 11:22:49AM +0100, Jakub Sitnicki wrote:
> > > This change has been suggested by Martin Lau [0] during a review of a
> > > related patch set that extends reuseport tests [1].
> > >
> > > Patches 1 & 2 address a warning due to unrecognized section name from
> > > libbpf when running reuseport tests. We don't want to carry this warning
> > > into test_progs.
> > >
> > > Patches 3-8 massage the reuseport tests to ease the switch to test_progs
> > > framework. The intention here is to show the work. Happy to squash these,
> > > if needed.
> > >
> > > Patches 9-10 do the actual move and conversion to test_progs.
> > >
> > > Output from a test_progs run after changes pasted below.
> >
> > Thank you for doing this conversion.
> > Looks great to me.
> >
> > Martin,
> > could you please review ?
> Looks awesome.  Appreciate for moving this to test_progs!
>
> Acked-by: Martin KaFai Lau <kafai@fb.com>

Applied. Thanks

      reply	other threads:[~2019-12-13 20:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 10:22 [PATCH bpf-next 00/10] Switch reuseport tests for test_progs framework Jakub Sitnicki
2019-12-12 10:22 ` [PATCH bpf-next 01/10] libbpf: Recognize SK_REUSEPORT programs from section name Jakub Sitnicki
2019-12-12 10:22 ` [PATCH bpf-next 02/10] selftests/bpf: Let libbpf determine program type " Jakub Sitnicki
2019-12-12 10:22 ` [PATCH bpf-next 03/10] selftests/bpf: Use sa_family_t everywhere in reuseport tests Jakub Sitnicki
2019-12-12 10:22 ` [PATCH bpf-next 04/10] selftests/bpf: Add helpers for getting socket family & type name Jakub Sitnicki
2019-12-12 10:22 ` [PATCH bpf-next 05/10] selftests/bpf: Unroll the main loop in reuseport test Jakub Sitnicki
2019-12-12 10:22 ` [PATCH bpf-next 06/10] selftests/bpf: Run reuseport tests in a loop Jakub Sitnicki
2019-12-12 10:22 ` [PATCH bpf-next 07/10] selftests/bpf: Propagate errors during setup for reuseport tests Jakub Sitnicki
2019-12-12 10:22 ` [PATCH bpf-next 08/10] selftests/bpf: Pull up printing the test name into test runner Jakub Sitnicki
2019-12-12 10:22 ` [PATCH bpf-next 09/10] selftests/bpf: Move reuseport tests under prog_tests/ Jakub Sitnicki
2019-12-12 10:22 ` [PATCH bpf-next 10/10] selftests/bpf: Switch reuseport tests for test_progs framework Jakub Sitnicki
2019-12-13  5:36 ` [PATCH bpf-next 00/10] " Alexei Starovoitov
2019-12-13 16:30   ` Martin Lau
2019-12-13 20:41     ` Alexei Starovoitov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAADnVQ+_4gCavtPnArq3RMWB4ZQNefEZeBMft8+6aSXJqwSAeA@mail.gmail.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=jakub@cloudflare.com \
    --cc=kafai@fb.com \
    --cc=kernel-team@cloudflare.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).