From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Martin KaFai Lau <kafai@fb.com>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Kernel Team <kernel-team@fb.com>,
Network Development <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Lawrence Brakmo <brakmo@fb.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
alexanderduyck@fb.com
Subject: Re: [bpf-next PATCH v3 0/5] selftests/bpf: Migrate test_tcpbpf_user to be a part of test_progs framework
Date: Tue, 3 Nov 2020 18:01:48 -0800 [thread overview]
Message-ID: <CAADnVQ+dApEP-6qJzKiEJNbdh4QgBfAJN5oOjVfKwDr4iHRtUQ@mail.gmail.com> (raw)
In-Reply-To: <20201104002014.tohvmzsxr2hhxjkt@kafai-mbp.dhcp.thefacebook.com>
On Tue, Nov 3, 2020 at 4:20 PM Martin KaFai Lau <kafai@fb.com> wrote:
>
> On Tue, Nov 03, 2020 at 01:34:40PM -0800, Alexander Duyck wrote:
> > Move the test functionality from test_tcpbpf_user into the test_progs
> > framework so that it will be run any time the test_progs framework is run.
> > This will help to prevent future test escapes as the individual tests, such
> > as test_tcpbpf_user, are less likely to be run by developers and CI
> > tests.
> >
> > As a part of moving it over the series goes through and updates the code to
> > make use of the existing APIs included in the test_progs framework. This is
> > meant to simplify and streamline the test code and avoid duplication of
> > effort.
> >
> > v2: Dropped test_tcpbpf_user from .gitignore
> > Replaced CHECK_FAIL calls with CHECK calls
> > Minimized changes in patch 1 when moving the file
> > Updated stg mail command line to display renames in submission
> > Added shutdown logic to end of run_test function to guarantee close
> > Added patch that replaces the two maps with use of global variables
> > v3: Left err at -1 while we are performing send/recv calls w/ data
> > Drop extra labels from test_tcpbpf_user in favor of keeping err label
> > Dropped redundant zero init for tcpbpf_globals result and key
> > Dropped replacing of "printf(" with "fprintf(stderr, "
> > Fixed error in use of ASSERT_OK_PTR which was skipping of run_test
> > Replaced "{ 0 }" with "{}" in init of global in test_tcpbpf_kern.c
> > Added "Acked-by" from Martin KaiFai Lau and Andrii Nakryiko
> Acked-by: Martin KaFai Lau <kafai@fb.com>
Applied. Thanks
prev parent reply other threads:[~2020-11-04 2:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 21:34 [bpf-next PATCH v3 0/5] selftests/bpf: Migrate test_tcpbpf_user to be a part of test_progs framework Alexander Duyck
2020-11-03 21:34 ` [bpf-next PATCH v3 1/5] selftests/bpf: Move test_tcppbf_user into test_progs Alexander Duyck
2020-11-04 2:10 ` patchwork-bot+netdevbpf
2020-11-03 21:34 ` [bpf-next PATCH v3 2/5] selftests/bpf: Drop python client/server in favor of threads Alexander Duyck
2020-11-03 21:35 ` [bpf-next PATCH v3 3/5] selftests/bpf: Replace EXPECT_EQ with ASSERT_EQ and refactor verify_results Alexander Duyck
2020-11-03 21:35 ` [bpf-next PATCH v3 4/5] selftests/bpf: Migrate tcpbpf_user.c to use BPF skeleton Alexander Duyck
2020-11-03 21:35 ` [bpf-next PATCH v3 5/5] selftest/bpf: Use global variables instead of maps for test_tcpbpf_kern Alexander Duyck
2020-11-04 0:20 ` [bpf-next PATCH v3 0/5] selftests/bpf: Migrate test_tcpbpf_user to be a part of test_progs framework Martin KaFai Lau
2020-11-04 2:01 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQ+dApEP-6qJzKiEJNbdh4QgBfAJN5oOjVfKwDr4iHRtUQ@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=alexanderduyck@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brakmo@fb.com \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).