From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Yonghong Song <yhs@fb.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v2 bpf-next 2/6] libbpf: rename static variables during linking
Date: Fri, 23 Apr 2021 16:05:53 -0700 [thread overview]
Message-ID: <CAADnVQ+h9eS0P9Jb0QZQ374WxNSF=jhFAiBV7czqhnJxV51m6A@mail.gmail.com> (raw)
In-Reply-To: <065e8768-b066-185f-48f9-7ca8f15a2547@fb.com>
On Fri, Apr 23, 2021 at 2:56 PM Yonghong Song <yhs@fb.com> wrote:
> >>>
> >>> -static volatile const __u32 print_len;
> >>> -static volatile const __u32 ret1;
> >>> +volatile const __u32 print_len = 0;
> >>> +volatile const __u32 ret1 = 0;
> >>
> >> I am little bit puzzled why bpf_iter_test_kern4.c is impacted. I think
> >> this is not in a static link test, right? The same for a few tests below.
> >
> > All the selftests are passed through a static linker, so it will
> > append obj_name to each static variable. So I just minimized use of
> > static variables to avoid too much code churn. If this variable was
> > static, it would have to be accessed as
> > skel->rodata->bpf_iter_test_kern4__print_len, for example.
>
> Okay this should be fine. selftests/bpf specific. I just feel that
> some people may get confused if they write/see a single program in
> selftest and they have to use obj_varname format and thinking this
> is a new standard, but actually it is due to static linking buried
> in Makefile. Maybe add a note in selftests/README.rst so we
> can point to people if there is confusion.
I'm not sure I understand.
Are you saying that
bpftool gen object out_file.o in_file.o
is no longer equivalent to llvm-strip ?
Since during that step static vars will get their names mangled?
So a good chunk of code that uses skeleton right now should either
1. don't do the linking step
or
2. adjust their code to use global vars
or
3. adjust the usage of skel.h in their corresponding user code
to accommodate mangled static names?
Did it get it right?
next prev parent reply other threads:[~2021-04-23 23:06 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 18:53 [PATCH v2 bpf-next 0/6] BPF static linker: support static vars and maps Andrii Nakryiko
2021-04-23 18:53 ` [PATCH v2 bpf-next 1/6] bpftool: strip const/volatile/restrict modifiers from .bss and .data vars Andrii Nakryiko
2021-04-23 20:02 ` Yonghong Song
2021-04-23 18:53 ` [PATCH v2 bpf-next 2/6] libbpf: rename static variables during linking Andrii Nakryiko
2021-04-23 20:24 ` Yonghong Song
2021-04-23 21:38 ` Andrii Nakryiko
2021-04-23 21:56 ` Yonghong Song
2021-04-23 23:05 ` Alexei Starovoitov [this message]
2021-04-23 23:26 ` Yonghong Song
2021-04-23 23:35 ` Alexei Starovoitov
2021-04-23 23:35 ` Andrii Nakryiko
2021-04-23 23:48 ` Alexei Starovoitov
2021-04-24 0:13 ` Andrii Nakryiko
2021-04-24 0:22 ` Alexei Starovoitov
2021-04-26 15:44 ` Andrii Nakryiko
2021-04-26 22:34 ` Alexei Starovoitov
2021-04-26 23:11 ` Andrii Nakryiko
2021-04-27 2:22 ` Alexei Starovoitov
2021-04-27 21:27 ` Andrii Nakryiko
2021-04-28 4:55 ` Alexei Starovoitov
2021-04-28 19:33 ` Andrii Nakryiko
2021-05-04 4:42 ` bpf libraries and static variables. Was: " Alexei Starovoitov
2021-05-05 5:22 ` Alexei Starovoitov
2021-05-06 22:54 ` Daniel Borkmann
2021-05-11 17:57 ` Andrii Nakryiko
2021-05-11 18:05 ` Andrii Nakryiko
2021-05-11 14:20 ` Lorenz Bauer
2021-05-11 18:04 ` Andrii Nakryiko
2021-05-11 18:59 ` Andrii Nakryiko
2021-05-11 23:05 ` Alexei Starovoitov
2021-05-12 13:40 ` Lorenz Bauer
2021-05-12 18:50 ` Andrii Nakryiko
2021-05-12 23:39 ` Alexei Starovoitov
2021-05-13 8:37 ` Lorenz Bauer
2021-05-13 15:41 ` Alexei Starovoitov
2021-04-24 2:36 ` Yonghong Song
2021-04-26 15:45 ` Andrii Nakryiko
2021-04-26 16:34 ` Yonghong Song
2021-04-23 18:53 ` [PATCH v2 bpf-next 3/6] libbpf: support static map definitions Andrii Nakryiko
2021-04-23 20:25 ` Yonghong Song
2021-04-23 18:53 ` [PATCH v2 bpf-next 4/6] bpftool: handle transformed static map names in BPF skeleton Andrii Nakryiko
2021-04-23 22:59 ` Yonghong Song
2021-04-23 18:53 ` [PATCH v2 bpf-next 5/6] selftests/bpf: extend linked_vars selftests with static variables Andrii Nakryiko
2021-04-23 23:03 ` Yonghong Song
2021-04-23 23:03 ` Yonghong Song
2021-04-23 18:53 ` [PATCH v2 bpf-next 6/6] selftests/bpf: extend linked_maps selftests with static maps Andrii Nakryiko
2021-04-23 23:11 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADnVQ+h9eS0P9Jb0QZQ374WxNSF=jhFAiBV7czqhnJxV51m6A@mail.gmail.com' \
--to=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).