From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A4FC433E0 for ; Thu, 13 Aug 2020 01:13:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6B2F206DA for ; Thu, 13 Aug 2020 01:13:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tgrJztZc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726529AbgHMBNL (ORCPT ); Wed, 12 Aug 2020 21:13:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbgHMBNL (ORCPT ); Wed, 12 Aug 2020 21:13:11 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C80DEC061383 for ; Wed, 12 Aug 2020 18:13:10 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id 140so2156654lfi.5 for ; Wed, 12 Aug 2020 18:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nWYdny5TPME+M+iQKECCVkJDywZUM3Lv5lxW+w10+Uo=; b=tgrJztZc+kUX3wLGWX1x2qIYi/P1Y0w57Fwtn+KBTKggXs4/8s3H9rKNGzaC7ABWsB QdJSD6/+ASdmBJDkH/ys4D/2RkyDDC6/3OgQ1gv3pICb1ESOamFdSxlFi81V+/YNrUyR VQybOqToBzJHElgO2I+L0SGSO9xxso5asFbC2JFMm4uKro2eMWZFx8W4Wrlcw7LvF8Mu er2wE3jvGoaSy6yvnwOxXi0ETmaOCnn5GphRPew6zTiLgcLFzTum/z9RoQBsy3aAEcx0 vuRBT1r8iKMJ7CN4jHUbLDLn7izw002QJ7rNfyarw1Ul4G0XTiXgwRt8TPGENbsOum3G htIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nWYdny5TPME+M+iQKECCVkJDywZUM3Lv5lxW+w10+Uo=; b=qI1TdQghvaOtWEQfYAiXHNYnryxdcfkRIhz9YMJHPkfcC1sWaNHZRrSJxhpKOkx2HI VN7cVJcj1znelMcrHVK/7aBmm74oUd18HR2gnUDylvFSn8k6BThNBVyGsLqPL1Jp7q6J Endos4OcSlLDtdX/k+foFhliTIxIxjJ4gLgTN/OM3trIom+QDodJn/rWr+4bjko3DsQe Hc6y1uBSdDrz1DYvLwJertMn/0xakxW5OhqdSIArv9k1TccEPh63ZhIRPyVVvnCJPi7B av/qbG1RxTwSXQVagrqQaFSNvgFqYlddWeeazO2/GonBY8f/Vi9clbOd161g7dC54JAp kMDg== X-Gm-Message-State: AOAM533qFfVu6oYDu7CcXh/2Wqhy0a8SRbXypKSszKUAkBg9xIyEKu+S sM5kuAN5XYTynPdJ9+pWsGBAq+zPdeasHa/7FRE= X-Google-Smtp-Source: ABdhPJzdYBv0N2cXnI9DnW86eF2VmzQK/xE/4X/QtgWDJ51uHEFGh2BFKbGgJOMC3H0deK7TJLYrp2lUSQxzHEdVuoc= X-Received: by 2002:a05:6512:74b:: with SMTP id c11mr931035lfs.119.1597281188620; Wed, 12 Aug 2020 18:13:08 -0700 (PDT) MIME-Version: 1.0 References: <20200812143909.3293280-1-jean-philippe@linaro.org> In-Reply-To: From: Alexei Starovoitov Date: Wed, 12 Aug 2020 18:12:57 -0700 Message-ID: Subject: Re: [PATCH bpf v2] libbpf: Handle GCC built-in types for Arm NEON To: Andrii Nakryiko Cc: Jean-Philippe Brucker , Alexei Starovoitov , Daniel Borkmann , Martin Lau , Song Liu , Yonghong Song , Andrii Nakryiko , john fastabend , KP Singh , bpf , linux-arm-kernel , Jakov Petrina Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Aug 12, 2020 at 10:35 AM Andrii Nakryiko wrote: > > On Wed, Aug 12, 2020 at 7:42 AM Jean-Philippe Brucker > wrote: > > > > When building Arm NEON (SIMD) code from lib/raid6/neon.uc, GCC emits > > DWARF information using a base type "__Poly8_t", which is internal to > > GCC and not recognized by Clang. This causes build failures when > > building with Clang a vmlinux.h generated from an arm64 kernel that was > > built with GCC. > > > > vmlinux.h:47284:9: error: unknown type name '__Poly8_t' > > typedef __Poly8_t poly8x16_t[16]; > > ^~~~~~~~~ > > > > The polyX_t types are defined as unsigned integers in the "Arm C > > Language Extension" document (101028_Q220_00_en). Emit typedefs based on > > standard integer types for the GCC internal types, similar to those > > emitted by Clang. > > > > Including linux/kernel.h to use ARRAY_SIZE() incidentally redefined > > max(), causing a build bug due to different types, hence the seemingly > > unrelated change. > > > > Reported-by: Jakov Petrina > > Signed-off-by: Jean-Philippe Brucker > > --- > > LGTM. > > Acked-by: Andrii Nakryiko Applied. Thanks