From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [RFC PATCH bpf-next 3/5] kbuild: Add CONFIG_DEBUG_INFO_BTF_MODULES option or module BTFs
Date: Thu, 5 Nov 2020 19:50:09 -0800 [thread overview]
Message-ID: <CAADnVQJ6jVho5Ka0Qe0wgFyoqZtByhDqUpOr0vmDQHw2JjGUEA@mail.gmail.com> (raw)
In-Reply-To: <CAEf4BzbRqmKL3=q+GB=7JvWNxEaOz4CVAcbLQKBxoHF-Gfpv=g@mail.gmail.com>
On Thu, Nov 5, 2020 at 7:48 PM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Thu, Nov 5, 2020 at 7:13 PM Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:
> >
> > On Wed, Nov 04, 2020 at 08:51:38PM -0800, Andrii Nakryiko wrote:
> > >
> > > +config DEBUG_INFO_BTF_MODULES
> > > + bool "Generate BTF for kernel modules"
> > > + def_bool y
> > > + depends on DEBUG_INFO_BTF && MODULES && PAHOLE_HAS_SPLIT_BTF
> >
> > Does it need to be a new config ?
> > Can the build ran pahole if DEBUG_INFO_BTF && MODULES && PAHOLE_HAS_SPLIT_BTF ?
>
> It probably doesn't. If I drop the "bool" line, it will become
> non-configurable calculated Kconfig value, convenient to use
> everywhere. All the rest will stay exactly the same. It's nice to not
> have to do "if defined(DEBUG_INFO_BTF) && defined(MODULES) &&
> defined(PAHOLE_HAS_SPLIT_BTF)" checks, but rather a simple "ifdef
> CONFIG_DEBUG_INFO_BTF_MODULES". Does that work?
Makes sense.
next prev parent reply other threads:[~2020-11-06 3:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 4:51 [RFC PATCH bpf-next 0/5] Integrate kernel module BTF support Andrii Nakryiko
2020-11-05 4:51 ` [RFC PATCH bpf-next 1/5] bpf: add in-kernel split " Andrii Nakryiko
2020-11-05 4:51 ` [RFC PATCH bpf-next 2/5] bpf: assign ID to vmlinux BTF and return extra info for BTF in GET_OBJ_INFO Andrii Nakryiko
2020-11-06 3:19 ` Alexei Starovoitov
2020-11-06 3:43 ` Andrii Nakryiko
2020-11-05 4:51 ` [RFC PATCH bpf-next 3/5] kbuild: Add CONFIG_DEBUG_INFO_BTF_MODULES option or module BTFs Andrii Nakryiko
2020-11-06 3:13 ` Alexei Starovoitov
2020-11-06 3:48 ` Andrii Nakryiko
2020-11-06 3:50 ` Alexei Starovoitov [this message]
2020-11-05 4:51 ` [RFC PATCH bpf-next 4/5] bpf: load and verify kernel " Andrii Nakryiko
2020-11-05 16:39 ` Jakub Kicinski
2020-11-05 16:46 ` Greg Kroah-Hartman
2020-11-05 16:58 ` Jakub Kicinski
2020-11-05 19:01 ` Andrii Nakryiko
2020-11-05 4:51 ` [RFC PATCH bpf-next 5/5] tools/bpftool: add support for in-kernel and named BTF in `btf show` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQJ6jVho5Ka0Qe0wgFyoqZtByhDqUpOr0vmDQHw2JjGUEA@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=acme@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).